You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/01/18 15:03:45 UTC

[GitHub] [hive] zabetak commented on a change in pull request #1875: HIVE-24601: Control CBO fallback behavior via property

zabetak commented on a change in pull request #1875:
URL: https://github.com/apache/hive/pull/1875#discussion_r559627202



##########
File path: common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
##########
@@ -1806,6 +1806,12 @@ private static void populateLlapDaemonVarsSet(Set<String> llapDaemonVarsSetLocal
 
     // CBO related
     HIVE_CBO_ENABLED("hive.cbo.enable", true, "Flag to control enabling Cost Based Optimizations using Calcite framework."),
+    HIVE_CBO_FALLBACK_STRATEGY("hive.cbo.fallback.strategy", "CONSERVATIVE", new StringSet("NEVER, CONSERVATIVE, ALWAYS, TEST"),

Review comment:
       Good catch @kgyrtkirk ! Fixed in https://github.com/apache/hive/pull/1875/commits/a0ed3355de858b9aa49ae6989966451b04029353 and added tests in https://github.com/apache/hive/pull/1875/commits/bb7c60ff43257f6a9de4db125a71e6f2328017ee and https://github.com/apache/hive/pull/1875/commits/2d28db68a1830c2c4c9212d3650cd78db5375a4e.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org