You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/07/29 17:43:26 UTC

[GitHub] [beam] rehmanmuradali commented on a change in pull request #12391: [BEAM-9839] OnTimerContext should not create a new one when processing each element/timer in FnApiDoFnRunner

rehmanmuradali commented on a change in pull request #12391:
URL: https://github.com/apache/beam/pull/12391#discussion_r462163357



##########
File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java
##########
@@ -2118,8 +2113,8 @@ public TimeDomain timeDomain(DoFn<InputT, OutputT> doFn) {
     }
 
     @Override
-    public K key() {
-      return key;
+    public Object key() {

Review comment:
       I think at the time of the initialization of OnTimerContext, we don't have information of Key type. @robertwb  




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org