You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jspwiki.apache.org by GitBox <gi...@apache.org> on 2020/12/06 09:14:36 UTC
[GitHub] [jspwiki] arturobernalg opened a new pull request #15: [JSPWIKI-1135] - Add dependabot config file
arturobernalg opened a new pull request #15:
URL: https://github.com/apache/jspwiki/pull/15
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jspwiki] juanpablo-santos merged pull request #15: [JSPWIKI-1135] - Add dependabot config file
Posted by GitBox <gi...@apache.org>.
juanpablo-santos merged pull request #15:
URL: https://github.com/apache/jspwiki/pull/15
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jspwiki] juanpablo-santos commented on a change in pull request #15: [JSPWIKI-1135] - Add dependabot config file
Posted by GitBox <gi...@apache.org>.
juanpablo-santos commented on a change in pull request #15:
URL: https://github.com/apache/jspwiki/pull/15#discussion_r546411406
##########
File path: .github/dependabot.yml
##########
@@ -0,0 +1,25 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+version: 2
+updates:
Review comment:
Hi,
according to [dependabot documentation](https://docs.github.com/en/free-pro-team@latest/github/administering-a-repository/configuration-options-for-dependency-updates#specifying-dependencies-and-versions-to-ignore) version's ranges can be excluded, so the file should have at least the following exclusions
* `javax.servlet:javax.servlet-api` should exclude the range `[3.2.0,)`
* `javax.servlet.jsp:javax.servlet.jsp-api` should exclude the range `[2.4.0,)`
* `org.apache.tomcat:*` should exclude the range `[10.0.0,)`
* we use only a couple of `embed` dependencies on the portable module, but using a wildcard seems safer on the long run
* `org.slf4j:*` should exclude the range `[1.8.0-beta1,2.0.0)`
* the range comes from a bit of a search on central + checking [version ordering](https://medium.com/@MichaKutz/legit-but-useless-maven-version-ranges-explained-d4ba66ac654) (cfr. with last section of the article)
* last, according to the documentation, the `Dockerfile` could/would also be checked for newer versions. In this case, I think it would be safe to just ignore it.
best regards,
juan pablo
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jspwiki] juanpablo-santos commented on a change in pull request #15: [JSPWIKI-1135] - Add dependabot config file
Posted by GitBox <gi...@apache.org>.
juanpablo-santos commented on a change in pull request #15:
URL: https://github.com/apache/jspwiki/pull/15#discussion_r548192748
##########
File path: .github/dependabot.yml
##########
@@ -0,0 +1,25 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+version: 2
+updates:
Review comment:
Just not specifying a `docker` `package-ecosystem` section should be enough. What I tried to mean on my previous comment is that we could also check for it, but it is not necessary, as the `Dockerfile` is currently fixed for Apache Tomcat 9.0 versions.
As for the inored dependencies/versions, they should go under the `maven` `package ecosystem`, the `github-actions` one should be deleted, as we're not currently using them. Somehow I missed this on the initial review..
thx,
juan pablo
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jspwiki] arturobernalg commented on a change in pull request #15: [JSPWIKI-1135] - Add dependabot config file
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on a change in pull request #15:
URL: https://github.com/apache/jspwiki/pull/15#discussion_r546417545
##########
File path: .github/dependabot.yml
##########
@@ -0,0 +1,25 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+version: 2
+updates:
Review comment:
Yep. Woking on it.
https://github.com/apache/jspwiki/pull/15/commits/c197a2f2e9a5b5624044e3c73e93bde8716fd30a
change to draft
Thanks JP,
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jspwiki] juanpablo-santos commented on a change in pull request #15: [JSPWIKI-1135] - Add dependabot config file
Posted by GitBox <gi...@apache.org>.
juanpablo-santos commented on a change in pull request #15:
URL: https://github.com/apache/jspwiki/pull/15#discussion_r548207846
##########
File path: .github/dependabot.yml
##########
@@ -0,0 +1,25 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+version: 2
+updates:
Review comment:
Remove the `github-actions` section and place the exclusions under the `maven` `package-ecosystem` one. Also, in this case, and if possible, squash the commits into one, so the commit history gets clearer, and we don't lose the commit authorship.
best regards,
juan pablo
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jspwiki] arturobernalg commented on a change in pull request #15: [JSPWIKI-1135] - Add dependabot config file
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on a change in pull request #15:
URL: https://github.com/apache/jspwiki/pull/15#discussion_r548201736
##########
File path: .github/dependabot.yml
##########
@@ -0,0 +1,25 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+version: 2
+updates:
Review comment:
mmmm.. so.... do I have to do anything else?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jspwiki] arturobernalg commented on a change in pull request #15: [JSPWIKI-1135] - Add dependabot config file
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on a change in pull request #15:
URL: https://github.com/apache/jspwiki/pull/15#discussion_r545582681
##########
File path: .github/dependabot.yml
##########
@@ -0,0 +1,25 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+version: 2
+updates:
Review comment:
mmmm
no clue. I'm gonna check if we can configure the bot to achieve what you asking.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jspwiki] juanpablo-santos commented on a change in pull request #15: [JSPWIKI-1135] - Add dependabot config file
Posted by GitBox <gi...@apache.org>.
juanpablo-santos commented on a change in pull request #15:
URL: https://github.com/apache/jspwiki/pull/15#discussion_r548192748
##########
File path: .github/dependabot.yml
##########
@@ -0,0 +1,25 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+version: 2
+updates:
Review comment:
Just not specifying a `docker` `package-ecosystem` section should be enough. What I tried to mean on my previous comment is that we could also check for it, but it is not necessary, as the `Dockerfile` is currently fixed for Apache Tomcat 9.0 versions.
As for the ignored dependencies/versions, they should go under the `maven` `package ecosystem`, the `github-actions` one should be deleted, as we're not currently using them. Somehow I missed this on the initial review..
thx,
juan pablo
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jspwiki] juanpablo-santos commented on a change in pull request #15: [JSPWIKI-1135] - Add dependabot config file
Posted by GitBox <gi...@apache.org>.
juanpablo-santos commented on a change in pull request #15:
URL: https://github.com/apache/jspwiki/pull/15#discussion_r545343859
##########
File path: .github/dependabot.yml
##########
@@ -0,0 +1,25 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+version: 2
+updates:
Review comment:
Hi @arturobernalg , thanks for the PR! A couple of questions / comments:
* would you mind including some exclusions for servlet-api, jsp-api and tomcat required dependencies? More precisely, it would be great if we could get notified about patch releases on those dependencies, but not on minor or major
* how does dependabot behave with versions not following semantic versioning? For instance, slf4j should stay on 1.7.30 and not be upgraded to latest 2.0.0-alpha1.
thanks + br,
juan pablo
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jspwiki] arturobernalg commented on a change in pull request #15: [JSPWIKI-1135] - Add dependabot config file
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on a change in pull request #15:
URL: https://github.com/apache/jspwiki/pull/15#discussion_r547233969
##########
File path: .github/dependabot.yml
##########
@@ -0,0 +1,25 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+version: 2
+updates:
Review comment:
Hi @juanpablo-santos
At the moment thinks are fallows:
`version: 2
updates:
- package-ecosystem: "maven"
directory: "/"
schedule:
interval: "daily"
- package-ecosystem: "github-actions"
directory: "/"
schedule:
interval: "daily"
ignore:
- dependency-name: javax.servlet:javax.servlet-api
versions: [3.2.0,)
- dependency-name: javax.servlet.jsp:javax.servlet.jsp-api
versions: [2.4.0,)
- dependency-name: org.apache.tomcat:*
versions: [10.0.0,)
- dependency-name: org.slf4j:*
versions: [1.8.0-beta1,2.0.0)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jspwiki] arturobernalg commented on a change in pull request #15: [JSPWIKI-1135] - Add dependabot config file
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on a change in pull request #15:
URL: https://github.com/apache/jspwiki/pull/15#discussion_r548212700
##########
File path: .github/dependabot.yml
##########
@@ -0,0 +1,25 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+version: 2
+updates:
Review comment:
Done and squash
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jspwiki] arturobernalg commented on a change in pull request #15: [JSPWIKI-1135] - Add dependabot config file
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on a change in pull request #15:
URL: https://github.com/apache/jspwiki/pull/15#discussion_r547233969
##########
File path: .github/dependabot.yml
##########
@@ -0,0 +1,25 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+version: 2
+updates:
Review comment:
Hi @juanpablo-santos
At the moment thinks are fallows:
version: 2
updates:
- package-ecosystem: "maven"
directory: "/"
schedule:
interval: "daily"
- package-ecosystem: "github-actions"
directory: "/"
schedule:
interval: "daily"
ignore:
- dependency-name: javax.servlet:javax.servlet-api
versions: [3.2.0,)
- dependency-name: javax.servlet.jsp:javax.servlet.jsp-api
versions: [2.4.0,)
- dependency-name: org.apache.tomcat:*
versions: [10.0.0,)
- dependency-name: org.slf4j:*
versions: [1.8.0-beta1,2.0.0)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jspwiki] arturobernalg commented on a change in pull request #15: [JSPWIKI-1135] - Add dependabot config file
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on a change in pull request #15:
URL: https://github.com/apache/jspwiki/pull/15#discussion_r546417545
##########
File path: .github/dependabot.yml
##########
@@ -0,0 +1,25 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+version: 2
+updates:
Review comment:
Yep. Woking on it.
https://github.com/apache/jspwiki/pull/15/commits/c197a2f2e9a5b5624044e3c73e93bde8716fd30a
Thanks JP,
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jspwiki] arturobernalg commented on pull request #15: [JSPWIKI-1135] - Add dependabot config file
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on pull request #15:
URL: https://github.com/apache/jspwiki/pull/15#issuecomment-739476822
Add commit with some fix in the javadoc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jspwiki] arturobernalg commented on a change in pull request #15: [JSPWIKI-1135] - Add dependabot config file
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on a change in pull request #15:
URL: https://github.com/apache/jspwiki/pull/15#discussion_r548108639
##########
File path: .github/dependabot.yml
##########
@@ -0,0 +1,25 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+version: 2
+updates:
Review comment:
Hi @juanpablo-santos JP. No idea of how ignore DockerFile
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org