You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by PSUdaemon <gi...@git.apache.org> on 2016/06/21 21:12:21 UTC
[GitHub] trafficserver pull request #728: TS-4572: Fix "Unchecked return value" (CID ...
GitHub user PSUdaemon opened a pull request:
https://github.com/apache/trafficserver/pull/728
TS-4572: Fix "Unchecked return value" (CID 1356972)
If the function returns an error value, the error value may be mistaken for a normal value.
In get_effective_host: Value returned from a function is not checked for errors before being used (CWE-252)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PSUdaemon/trafficserver TS-4572
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/728.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #728
----
commit 3a3cb0ac6e3e4af2023c78f7cfc942f2318e2719
Author: Phil Sorber <so...@apache.org>
Date: 2016-06-21T21:11:01Z
TS-4572: Fix "Unchecked return value" (CID 1356972)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #728: TS-4572: Fix "Unchecked return value" (CID 1356972...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/728
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/314/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #728: TS-4572: Fix "Unchecked return value" (CID 1356972...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/728
Fwiw, this is where I completely disagree with jpeach, an assert with side effects is simply wrong. Even if it's a release assert. I'd be ok if we changed the name of the TSReleaseAssert() to something that's not "assert". The real danger is that someone relaxes it from a release assert to a debug assert, and then it'll obviously fail completely.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #728: TS-4572: Fix "Unchecked return value" (CID 1356972...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/728
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/208/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #728: TS-4572: Fix "Unchecked return value" (CID 1356972...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/728
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #728: TS-4572: Fix "Unchecked return value" (CID ...
Posted by PSUdaemon <gi...@git.apache.org>.
Github user PSUdaemon closed the pull request at:
https://github.com/apache/trafficserver/pull/728
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #728: TS-4572: Fix "Unchecked return value" (CID 1356972...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/728
My preference you be to just ``TSReleaseAssert`` this, but it does look like the plugin handles a ``NULL`` hostname, so \U0001f44d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #728: TS-4572: Fix "Unchecked return value" (CID 1356972...
Posted by bryancall <gi...@git.apache.org>.
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/728
\U0001f44d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #728: TS-4572: Fix "Unchecked return value" (CID 1356972...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/728
trying again ... [approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---