You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/13 17:05:50 UTC

[GitHub] [arrow] lidavidm commented on a change in pull request #11940: ARROW-12768: [C++] Stricter signed zero comparison in tests

lidavidm commented on a change in pull request #11940:
URL: https://github.com/apache/arrow/pull/11940#discussion_r767952667



##########
File path: cpp/src/arrow/compare.h
##########
@@ -48,6 +48,16 @@ class EqualOptions {
     return res;
   }
 
+  /// Whether or not zeros with differing signs are considered equal.
+  bool signed_zeros_equal() const { return signed_zeros_equal_; }

Review comment:
       signed_zeros_equal sounds fine to me.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org