Process / contribution guide

[Davor Bonaci <da...@google.com.INVALID>]

Hi everyone,
I wanted to send a quick remainder that we should all try to follow our own
contribution guide.

Recently, there have been several cases where commits didn't go through the
pull requests / review, pull requests that were merge differently, not
closed automatically by tooling, etc.

I'd kindly ask to try your best to follow our own process. That said, we
now have more experience in this type of development -- if there's any
point that should be re-discussed, please bring it up for consideration.

Thanks!

Davor

Re: Process / contribution guide

[Jesse Anderson <je...@smokinghand.com>]

I'd add some more information about checkstyle. That's the one that trips
me up. I haven't dealt with checkstyle before and the rules violations
output in mvn isn't very clear.

Right now it's discussed in the committer section, but it affects
contributors too.

I'd add some discussion of the common ones I hit like extra whitespace and
import order. I think the other ones were pretty clear. I'd also add the
mvn command to only run a checkstyle check. Also add the command to skip
the checkstyle (mvn clean install -Dcheckstyle.skip=true).

Thanks,

Jesse

On Sun, May 8, 2016 at 12:52 PM Jean-Baptiste Onofré <jb...@nanthrax.net>
wrote:

> Hi Davor,
>
> My bad: I did a cherry-pick instead of a merge on a PR.
>
> I will now be careful to apply a merge.
>
> Sorry about that.
>
> Regards
> JB
>
> On 05/08/2016 09:08 PM, Davor Bonaci wrote:
> > Hi everyone,
> > I wanted to send a quick remainder that we should all try to follow our
> own
> > contribution guide.
> >
> > Recently, there have been several cases where commits didn't go through
> the
> > pull requests / review, pull requests that were merge differently, not
> > closed automatically by tooling, etc.
> >
> > I'd kindly ask to try your best to follow our own process. That said, we
> > now have more experience in this type of development -- if there's any
> > point that should be re-discussed, please bring it up for consideration.
> >
> > Thanks!
> >
> > Davor
> >
>
> --
> Jean-Baptiste Onofré
> jbonofre@apache.org
> http://blog.nanthrax.net
> Talend - http://www.talend.com
>

Re: Process / contribution guide

[Jean-Baptiste Onofré <jb...@nanthrax.net>]

Hi Davor,

My bad: I did a cherry-pick instead of a merge on a PR.

I will now be careful to apply a merge.

Sorry about that.

Regards
JB

On 05/08/2016 09:08 PM, Davor Bonaci wrote:
> Hi everyone,
> I wanted to send a quick remainder that we should all try to follow our own
> contribution guide.
>
> Recently, there have been several cases where commits didn't go through the
> pull requests / review, pull requests that were merge differently, not
> closed automatically by tooling, etc.
>
> I'd kindly ask to try your best to follow our own process. That said, we
> now have more experience in this type of development -- if there's any
> point that should be re-discussed, please bring it up for consideration.
>
> Thanks!
>
> Davor
>

-- 
Jean-Baptiste Onofr�
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com