You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "chihumyum (via GitHub)" <gi...@apache.org> on 2026/09/06 08:17:28 UTC

[PR] test(desktop): pin the About reader's missing-provider throw [maka]

chihumyum opened a new pull request, #4905:
URL: https://github.com/apache/maka/pull/4905

   ## Summary
   
   Follow-up to #4498, taking the two non-blocking P3s from the re-review; the commit carrying them was pushed after the merge, so it lands here.
   
   - `AppUpdateAboutProjectionConsumer` throws when mounted outside `AppUpdateProvider`, but `app-update-provider-scope.test.ts` covered only the mounted path. Add the `assert.throws` render case (React's `act` rethrows the uncaught render error) and assert the reader's callback never ran.
   - trim the `AboutUpdateStatusRow` doc comment to the sentence the next editor needs, that it is a component because the action guard is a hook; the ownership argument lives in #4498's body.
   
   Refs #4582
   
   ## Verification
   
   - Node 24: desktop `test:dist` 2312/2312, `@maka/desktop` typecheck, lint, format:check
   - `check:renderer-architecture --base upstream/main`, `check:app-shell-hooks`, Astryx inventory, Knip (`apps/desktop`), ASF headers, `git diff --check`
   - the new case fails when the Consumer's throw is replaced by `return null` (checked locally before pushing)
   
   ## AI use
   
   Select exactly one:
   
   - [ ] No generative tool made a substantive contribution
   - [x] Generative tooling made a substantive contribution
   
   Tool(s) and scope: Claude Code wrote the test case and the comment trim and ran the verification; the human contributor reviewed the work and chose to submit it.
   
   ## Checklist
   
   - [x] Tests cover the change and fail without it
   - [x] Lint, format, typecheck and the affected suites pass locally
   
   Does this PR entail a change in behavior?
   
   - [ ] Yes — described under Summary above
   - [x] No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org


Re: [PR] test(desktop): pin the About reader's missing-provider throw [maka]

Posted by "me2seeks (via GitHub)" <gi...@apache.org>.
me2seeks merged PR #4905:
URL: https://github.com/apache/maka/pull/4905


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org