You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by ab...@apache.org on 2022/08/01 13:01:27 UTC
[incubator-devlake] branch main updated (3a0f52ee -> 8b054177)
This is an automated email from the ASF dual-hosted git repository.
abeizn pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-devlake.git
from 3a0f52ee fix: jira connection is deleted when enckey is error (#2648)
new f1f092b4 fix: github.ExtractApiPullRequestReviews panic
new 8b054177 fix: fix github.ExtractApiEvents panic
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
plugins/github/tasks/event_extractor.go | 2 +-
plugins/github/tasks/pr_review_extractor.go | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
[incubator-devlake] 02/02: fix: fix github.ExtractApiEvents panic
Posted by ab...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
abeizn pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-devlake.git
commit 8b0541777b091655baba1a9039bf712fcb0ce864
Author: zhangliang <li...@merico.dev>
AuthorDate: Mon Aug 1 20:49:01 2022 +0800
fix: fix github.ExtractApiEvents panic
---
plugins/github/tasks/event_extractor.go | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/plugins/github/tasks/event_extractor.go b/plugins/github/tasks/event_extractor.go
index c3fd6e69..8d87c2db 100644
--- a/plugins/github/tasks/event_extractor.go
+++ b/plugins/github/tasks/event_extractor.go
@@ -63,7 +63,7 @@ func ExtractApiEvents(taskCtx core.SubTaskContext) error {
return nil, err
}
results := make([]interface{}, 0, 1)
- if body.GithubId == 0 {
+ if body.GithubId == 0 || body.Actor == nil {
return nil, nil
}
githubIssueEvent, err := convertGithubEvent(body, data.Options.ConnectionId)
[incubator-devlake] 01/02: fix: github.ExtractApiPullRequestReviews panic
Posted by ab...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
abeizn pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-devlake.git
commit f1f092b4898a77e3099bca1417646255f9f669c6
Author: zhangliang <li...@merico.dev>
AuthorDate: Mon Aug 1 20:30:19 2022 +0800
fix: github.ExtractApiPullRequestReviews panic
---
plugins/github/tasks/pr_review_extractor.go | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/plugins/github/tasks/pr_review_extractor.go b/plugins/github/tasks/pr_review_extractor.go
index aed145d4..f994a0e0 100644
--- a/plugins/github/tasks/pr_review_extractor.go
+++ b/plugins/github/tasks/pr_review_extractor.go
@@ -71,7 +71,7 @@ func ExtractApiPullRequestReviews(taskCtx core.SubTaskContext) error {
if err != nil {
return nil, err
}
- if apiPullRequestReview.State == "PENDING" {
+ if apiPullRequestReview.State == "PENDING" || apiPullRequestReview.User == nil {
return nil, nil
}
pull := &SimplePr{}