You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@forrest.apache.org by "David Crossley (JIRA)" <ji...@apache.org> on 2006/01/13 11:46:20 UTC
[jira] Created: (FOR-785) plugins/*/skinconf.xml does not validate
since using entity to ease management
plugins/*/skinconf.xml does not validate since using entity to ease management
------------------------------------------------------------------------------
Key: FOR-785
URL: http://issues.apache.org/jira/browse/FOR-785
Project: Forrest
Type: Bug
Components: Plugins (general issues)
Versions: 0.8-dev
Reporter: David Crossley
Fix For: 0.8-dev
Recently i split the skinconf.xml for each plugin to refer to common stuff via an external entity. Works nicely.
Okay, i admit it ... forgot to do 'build test' :-) and it doesn't validate. The DTD insists on having the elements in a specific order.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (FOR-785) plugins/*/skinconf.xml does not
validate since using entity to ease management
Posted by "Gavin (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/FOR-785?page=comments#action_12417076 ]
Gavin commented on FOR-785:
---------------------------
Ok,
So I altered the DTD and moved project-name and project-description to the end.
This works fine and validates, have I missed something as to why we can not moved these to the end, or shall I send a patch in?
(The produced site still looks the same)
(Another Alternative would be use variables for these, haven't worked that out though)
> plugins/*/skinconf.xml does not validate since using entity to ease management
> ------------------------------------------------------------------------------
>
> Key: FOR-785
> URL: http://issues.apache.org/jira/browse/FOR-785
> Project: Forrest
> Type: Bug
> Components: Plugins (general issues)
> Versions: 0.8-dev
> Reporter: David Crossley
> Fix For: 0.8-dev
>
> Recently i split the skinconf.xml for each plugin to refer to common stuff via an external entity. Works nicely.
> Okay, i admit it ... forgot to do 'build test' :-) and it doesn't validate. The DTD insists on having the elements in a specific order.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (FOR-785) plugins/*/skinconf.xml does not validate
since using entity to ease management
Posted by "David Crossley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/FOR-785?page=all ]
David Crossley updated FOR-785:
-------------------------------
Fix Version: 0.9
(was: 0.8-dev)
See some discussion following that on the the dev list. Note that this only affects our own plugins. Delaying until 0.9
> plugins/*/skinconf.xml does not validate since using entity to ease management
> ------------------------------------------------------------------------------
>
> Key: FOR-785
> URL: http://issues.apache.org/jira/browse/FOR-785
> Project: Forrest
> Type: Bug
> Components: Plugins (general issues)
> Versions: 0.8-dev
> Reporter: David Crossley
> Fix For: 0.9
> Attachments: dtdchanges.diff, enableValidatePlugins.diff
>
> Recently i split the skinconf.xml for each plugin to refer to common stuff via an external entity. Works nicely.
> Okay, i admit it ... forgot to do 'build test' :-) and it doesn't validate. The DTD insists on having the elements in a specific order.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
Re: [jira] Commented: (FOR-785) plugins/*/skinconf.xml does not validate since using entity to ease management
Posted by David Crossley <cr...@apache.org>.
Gav.... wrote:
>
> > David Crossley commented on FOR-785:
> > ------------------------------------
> >
> > Wait Gavin. We cannot do these changes because it will break everyone's
> > skinconf.xml in their existing projects.
>
> Yes, sorry, heres me thinking it would only affect plugins.
Even so, i would advise not to rush ahead to implement
something until the schema issues are decided.
> So, what to do, is there another way, or do we revise the version numbers,
> Something like
>
> Skinconfig-v07-1.dtd becomes Skinconfig-v08-1.dtd and rename the entitys
> file to Skinconfig-common-plugins-08-1.xml
I reckon that we should not even try to modify
the DTD just to suit our internal management of
the plugin's skinconf.xml files.
> Mind you, it will only break 'everyones' skinconf.xml if they are using
> trunk, and this is a fix for 0.8-dev to be released soon .
If we continue to use the same DTD version number,
then everyone's current project would be broken when
they upgrade to 0.8
If we changed version numbers of the DTD, then the users
could upgrade skinconf.xml as they choose. But it is a
lot of work for zero gain on their part.
If we subsequently add any new capability to skinconf.xml
then people are forced to make the change.
> This is an issue
> on the roadmap for its release, so let me know what way you want to go to
> get this issue cleared off the roadmap.
I reckon that we should delay this until 0.9-dev.
A better solution might be to use RELAX NG
rather than DTD for skinconf.xml
However, there is probably going to be a
move away from using skinconf.xml
> As for the plugins themselves, the validation was turned off as a workaround
> until a fix was found, it should not be the default setting. I should still
> continue to fix validation and 'ant test' errors for the rest of the plugins
> if I can.
There should not be any plugins that are broken
due to their skinconf.xml file - it is so minimal.
(Apart from the known issue with input.PhotoGallery)
For sure, there might be other xml validation issues
in plugins that need attention. That would definitely
be good to verify prior to release.
-David
RE: [jira] Commented: (FOR-785) plugins/*/skinconf.xml does not validate since using entity to ease management
Posted by "Gav...." <br...@brightontown.com.au>.
> -----Original Message-----
> From: David Crossley (JIRA) [mailto:jira@apache.org]
> Sent: Friday, 23 June 2006 10:06 AM
> To: dev@forrest.apache.org
> Subject: [jira] Commented: (FOR-785) plugins/*/skinconf.xml does not
> validate since using entity to ease management
>
> [ http://issues.apache.org/jira/browse/FOR-
> 785?page=comments#action_12417403 ]
>
> David Crossley commented on FOR-785:
> ------------------------------------
>
> Wait Gavin. We cannot do these changes because it will break everyone's
> skinconf.xml in their existing projects.
Yes, sorry, heres me thinking it would only affect plugins.
So, what to do, is there another way, or do we revise the version numbers,
Something like
Skinconfig-v07-1.dtd becomes Skinconfig-v08-1.dtd and rename the entitys
file to Skinconfig-common-plugins-08-1.xml
Mind you, it will only break 'everyones' skinconf.xml if they are using
trunk, and this is a fix for 0.8-dev to be released soon . This is an issue
on the roadmap for its release, so let me know what way you want to go to
get this issue cleared off the roadmap.
As for the plugins themselves, the validation was turned off as a workaround
until a fix was found, it should not be the default setting. I should still
continue to fix validation and 'ant test' errors for the rest of the plugins
if I can.
Wdyt?
Gav...
>
> > plugins/*/skinconf.xml does not validate since using entity to ease
> management
> > ------------------------------------------------------------------------
> ------
> >
> > Key: FOR-785
> > URL: http://issues.apache.org/jira/browse/FOR-785
> > Project: Forrest
> > Type: Bug
>
> > Components: Plugins (general issues)
> > Versions: 0.8-dev
> > Reporter: David Crossley
> > Fix For: 0.8-dev
> > Attachments: dtdchanges.diff, enableValidatePlugins.diff
> >
> > Recently i split the skinconf.xml for each plugin to refer to common
> stuff via an external entity. Works nicely.
> > Okay, i admit it ... forgot to do 'build test' :-) and it doesn't
> validate. The DTD insists on having the elements in a specific order.
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators:
> http://issues.apache.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see:
> http://www.atlassian.com/software/jira
>
>
>
> --
> No virus found in this incoming message.
> Checked by AVG Free Edition.
> Version: 7.1.394 / Virus Database: 268.9.2/373 - Release Date: 6/22/2006
[jira] Commented: (FOR-785) plugins/*/skinconf.xml does not
validate since using entity to ease management
Posted by "David Crossley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/FOR-785?page=comments#action_12417403 ]
David Crossley commented on FOR-785:
------------------------------------
Wait Gavin. We cannot do these changes because it will break everyone's skinconf.xml in their existing projects.
> plugins/*/skinconf.xml does not validate since using entity to ease management
> ------------------------------------------------------------------------------
>
> Key: FOR-785
> URL: http://issues.apache.org/jira/browse/FOR-785
> Project: Forrest
> Type: Bug
> Components: Plugins (general issues)
> Versions: 0.8-dev
> Reporter: David Crossley
> Fix For: 0.8-dev
> Attachments: dtdchanges.diff, enableValidatePlugins.diff
>
> Recently i split the skinconf.xml for each plugin to refer to common stuff via an external entity. Works nicely.
> Okay, i admit it ... forgot to do 'build test' :-) and it doesn't validate. The DTD insists on having the elements in a specific order.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (FOR-785) plugins/*/skinconf.xml does not
validate since using entity to ease management
Posted by "Gavin (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/FOR-785?page=comments#action_12417244 ]
Gavin commented on FOR-785:
---------------------------
Yes, I changed the forrest-validate.skinconf to = true again before testing (also you can 'forrest validate-skinconf' on the CLI.)
I will send a patch later and see what you think.
> plugins/*/skinconf.xml does not validate since using entity to ease management
> ------------------------------------------------------------------------------
>
> Key: FOR-785
> URL: http://issues.apache.org/jira/browse/FOR-785
> Project: Forrest
> Type: Bug
> Components: Plugins (general issues)
> Versions: 0.8-dev
> Reporter: David Crossley
> Fix For: 0.8-dev
>
> Recently i split the skinconf.xml for each plugin to refer to common stuff via an external entity. Works nicely.
> Okay, i admit it ... forgot to do 'build test' :-) and it doesn't validate. The DTD insists on having the elements in a specific order.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (FOR-785) plugins/*/skinconf.xml does not validate
since using entity to ease management
Posted by "Gavin (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/FOR-785?page=all ]
Gavin updated FOR-785:
----------------------
Attachment: dtdchanges.diff
dtdchanges.diff cures problems associated with plugins failing validation.
I am working through the plugins and have almost finished the main plugins.
The fact that validation for these plugins has been turned off means that a few
errors have crept in to some of them.
listLocations needed a file altering for it pass validation
OpenOffice needed some alterations also.
PhotoGallery and ProjectInfo both pass validation but fail the Ant Test due to some other errors, so I will leave them off of this round of patched and just submit the ones which pass - which is now all of them bar those two.
I have yet to test the WhiteBoard Plugins so will leave them until later.
Another patch will the passing plugin alterations I will post in the morning.
> plugins/*/skinconf.xml does not validate since using entity to ease management
> ------------------------------------------------------------------------------
>
> Key: FOR-785
> URL: http://issues.apache.org/jira/browse/FOR-785
> Project: Forrest
> Type: Bug
> Components: Plugins (general issues)
> Versions: 0.8-dev
> Reporter: David Crossley
> Fix For: 0.8-dev
> Attachments: dtdchanges.diff
>
> Recently i split the skinconf.xml for each plugin to refer to common stuff via an external entity. Works nicely.
> Okay, i admit it ... forgot to do 'build test' :-) and it doesn't validate. The DTD insists on having the elements in a specific order.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (FOR-785) plugins/*/skinconf.xml does not
validate since using entity to ease management
Posted by "David Crossley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/FOR-785?page=comments#action_12417217 ]
David Crossley commented on FOR-785:
------------------------------------
How did you test it? See my comment above about plugins/* forrest.validate.skinconf=false. If you have a solution, then please send a patch. Sorry, i don't know what you mean by "variables" in a DTD.
> plugins/*/skinconf.xml does not validate since using entity to ease management
> ------------------------------------------------------------------------------
>
> Key: FOR-785
> URL: http://issues.apache.org/jira/browse/FOR-785
> Project: Forrest
> Type: Bug
> Components: Plugins (general issues)
> Versions: 0.8-dev
> Reporter: David Crossley
> Fix For: 0.8-dev
>
> Recently i split the skinconf.xml for each plugin to refer to common stuff via an external entity. Works nicely.
> Okay, i admit it ... forgot to do 'build test' :-) and it doesn't validate. The DTD insists on having the elements in a specific order.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (FOR-785) plugins/*/skinconf.xml does not
validate since using entity to ease management
Posted by "David Crossley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/FOR-785?page=comments#action_12362626 ]
David Crossley commented on FOR-785:
------------------------------------
Added a workaround to each forrest.properties ... forrest.validate.skinconf=false
Will investigate other solutions ASAP.
> plugins/*/skinconf.xml does not validate since using entity to ease management
> ------------------------------------------------------------------------------
>
> Key: FOR-785
> URL: http://issues.apache.org/jira/browse/FOR-785
> Project: Forrest
> Type: Bug
> Components: Plugins (general issues)
> Versions: 0.8-dev
> Reporter: David Crossley
> Fix For: 0.8-dev
>
> Recently i split the skinconf.xml for each plugin to refer to common stuff via an external entity. Works nicely.
> Okay, i admit it ... forgot to do 'build test' :-) and it doesn't validate. The DTD insists on having the elements in a specific order.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (FOR-785) plugins/*/skinconf.xml does not validate
since using entity to ease management
Posted by "Gavin (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/FOR-785?page=all ]
Gavin updated FOR-785:
----------------------
Attachment: enableValidatePlugins.diff
enableValidatePlugins turns all of the main plugins into 'forrest.validate.skinconf=true' except those that do not pass 'Ant Test' . Other minor work performed on a few files to get them to validate/pass ant test again.
> plugins/*/skinconf.xml does not validate since using entity to ease management
> ------------------------------------------------------------------------------
>
> Key: FOR-785
> URL: http://issues.apache.org/jira/browse/FOR-785
> Project: Forrest
> Type: Bug
> Components: Plugins (general issues)
> Versions: 0.8-dev
> Reporter: David Crossley
> Fix For: 0.8-dev
> Attachments: dtdchanges.diff, enableValidatePlugins.diff
>
> Recently i split the skinconf.xml for each plugin to refer to common stuff via an external entity. Works nicely.
> Okay, i admit it ... forgot to do 'build test' :-) and it doesn't validate. The DTD insists on having the elements in a specific order.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (FOR-785) plugins/*/skinconf.xml does not validate
since using entity to ease management
Posted by "Tim Williams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FOR-785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Williams updated FOR-785:
-----------------------------
Fix Version/s: 0.10
(was: 0.9-dev)
> plugins/*/skinconf.xml does not validate since using entity to ease management
> ------------------------------------------------------------------------------
>
> Key: FOR-785
> URL: https://issues.apache.org/jira/browse/FOR-785
> Project: Forrest
> Issue Type: Bug
> Components: Plugins (general issues)
> Affects Versions: 0.8
> Reporter: David Crossley
> Fix For: 0.10
>
> Attachments: dtdchanges.diff, enableValidatePlugins.diff
>
>
> Recently i split the skinconf.xml for each plugin to refer to common stuff via an external entity. Works nicely.
> Okay, i admit it ... forgot to do 'build test' :-) and it doesn't validate. The DTD insists on having the elements in a specific order.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.