[jira] Commented: (HDFS-1205) FSDatasetAsyncDiskService should name its threads

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-1205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12883056#action_12883056 ] 

Hadoop QA commented on HDFS-1205:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12447006/hdfs-1205-0.20.txt
  against trunk revision 957669.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 patch.  The patch command could not apply the patch.

Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/406/console

This message is automatically generated.

> FSDatasetAsyncDiskService should name its threads
> -------------------------------------------------
>
>                 Key: HDFS-1205
>                 URL: https://issues.apache.org/jira/browse/HDFS-1205
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: data-node
>    Affects Versions: 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: hdfs-1205-0.20.txt, hdfs-1205.txt
>
>
> FSDatasetAsyncService creates threads but doesn't name them. The ThreadFactory should name them with the volume they work on as well as a thread index.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.