You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Jacopo Cappellato (JIRA)" <ji...@apache.org> on 2012/11/20 18:20:58 UTC
[jira] [Commented] (OFBIZ-5080) Screen Cache Not working
[ https://issues.apache.org/jira/browse/OFBIZ-5080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501311#comment-13501311 ]
Jacopo Cappellato commented on OFBIZ-5080:
------------------------------------------
It seems that you are right and it has been broken a long time ago during a code refactoring by the following commit:
{code}
Author: doogie
Date: Mon Nov 23 03:03:59 2009
New Revision: 883226
URL: http://svn.apache.org/viewvc?rev=883226&view=rev
Log:
Use getOrCreateUtilCache here too.
Modified:
ofbiz/trunk/framework/widget/src/org/ofbiz/widget/cache/AbstractCache.java
Modified: ofbiz/trunk/framework/widget/src/org/ofbiz/widget/cache/AbstractCache.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/cache/AbstractCache.java?rev=883226&r1=883225&r2=883226&view=diff
==============================================================================
--- ofbiz/trunk/framework/widget/src/org/ofbiz/widget/cache/AbstractCache.java (original)
+++ ofbiz/trunk/framework/widget/src/org/ofbiz/widget/cache/AbstractCache.java Mon Nov 23 03:03:59 2009
@@ -49,14 +49,7 @@
}
protected UtilCache<WidgetContextCacheKey, GenericWidgetOutput> getOrCreateCache(String widgetName) {
- synchronized (UtilCache.utilCacheTable) {
- String name = getCacheName(widgetName);
- UtilCache<WidgetContextCacheKey, GenericWidgetOutput> cache = UtilCache.findCache(name);
- if (cache == null) {
- cache = UtilCache.createUtilCache(name, 0, 0, true);
- cache.setPropertiesParams(new String[] {name});
- }
- return cache;
- }
+ String name = getCacheName(widgetName);
+ return UtilCache.getOrCreateUtilCache(widgetName, 0, 0, 0, true, false, name);
}
}
{code}
> Screen Cache Not working
> ------------------------
>
> Key: OFBIZ-5080
> URL: https://issues.apache.org/jira/browse/OFBIZ-5080
> Project: OFBiz
> Issue Type: Bug
> Components: ALL APPLICATIONS
> Affects Versions: SVN trunk, Release 11.04.01
> Reporter: K Sharad Bhushan
> Assignee: Jacopo Cappellato
> Priority: Minor
> Labels: patch
> Fix For: SVN trunk
>
> Attachments: AbstractCache.java.patch
>
>
> I have been trying to use screen cache, and identified that it was not working as expected.
> When debugged i have found that the key name used by cache and key name used for look up in for a cache were not same.
> I have corrected that and have tested in my enviornment.Not sure if any one was using it
> Attaching the patch
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira