[GitHub] [iceberg] szehon-ho commented on a diff in pull request #4847: Spark 3.2: Add snapshot-id filter property to AllManifest table

[GitBox <gi...@apache.org>]

szehon-ho commented on code in PR #4847:
URL: https://github.com/apache/iceberg/pull/4847#discussion_r883255609


##########
core/src/main/java/org/apache/iceberg/ScanProperties.java:
##########
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iceberg;
+
+public class ScanProperties {

Review Comment:
   @rdblue yea , I considered that.  My thought at the time is that same manifest may have different reference_snapshot_id .  Currently I guess we don't do de-duplication in all-manifest, but this would enforce that we return one manifest per reference_snapshot_id (ie, for an append-only table, the first manifest would appear as many times as snapshots.).  Also seems like this would require a bit complex code like adding a ProjectionEvaluator for snapshot filters.  Not totally against it, and maybe this is a useful feature even outside, but seems a bit harder to do in my view.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org