You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Vladimir Ivanov (JIRA)" <ji...@apache.org> on 2006/07/26 10:40:13 UTC
[jira] Created: (HARMONY-981) [drlvm][build] link to the CLASSLIB
is hardcoded into build.xml
[drlvm][build] link to the CLASSLIB is hardcoded into build.xml
---------------------------------------------------------------
Key: HARMONY-981
URL: http://issues.apache.org/jira/browse/HARMONY-981
Project: Harmony
Issue Type: Bug
Components: DRLVM
Reporter: Vladimir Ivanov
link to the CLASSLIB is hardcoded into build.xml (line 65) as
<property name="external.dep.CLASSLIB.loc" value="../../../../classlib/trunk" />
instead of use the predefined property from property file. Something like that:
<property name="external.dep.CLASSLIB.loc" value="${CLASSLIB_HOME}" />
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-981) [drlvm][build] link to the CLASSLIB
is hardcoded into build.xml
Posted by "Geir Magnusson Jr (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-981?page=all ]
Geir Magnusson Jr reassigned HARMONY-981:
-----------------------------------------
Assignee: Geir Magnusson Jr
> [drlvm][build] link to the CLASSLIB is hardcoded into build.xml
> ---------------------------------------------------------------
>
> Key: HARMONY-981
> URL: http://issues.apache.org/jira/browse/HARMONY-981
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Vladimir Ivanov
> Assigned To: Geir Magnusson Jr
>
> link to the CLASSLIB is hardcoded into build.xml (line 65) as
> <property name="external.dep.CLASSLIB.loc" value="../../../../classlib/trunk" />
> instead of use the predefined property from property file. Something like that:
> <property name="external.dep.CLASSLIB.loc" value="${CLASSLIB_HOME}" />
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-981) [drlvm][build] link to the CLASSLIB
is hardcoded into build.xml
Posted by "Geir Magnusson Jr (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-981?page=all ]
Geir Magnusson Jr resolved HARMONY-981.
---------------------------------------
Resolution: Fixed
I added support for a "drlvm.properties" file to be read first from the drlvm/build directory, and then from user home directory, that allows overrides to be set easily and repeatable.
it's optional - you can just still pass in via -D as well.
Checked in r428033
> [drlvm][build] link to the CLASSLIB is hardcoded into build.xml
> ---------------------------------------------------------------
>
> Key: HARMONY-981
> URL: http://issues.apache.org/jira/browse/HARMONY-981
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Vladimir Ivanov
> Assigned To: Geir Magnusson Jr
>
> link to the CLASSLIB is hardcoded into build.xml (line 65) as
> <property name="external.dep.CLASSLIB.loc" value="../../../../classlib/trunk" />
> instead of use the predefined property from property file. Something like that:
> <property name="external.dep.CLASSLIB.loc" value="${CLASSLIB_HOME}" />
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-981) [drlvm][build] link to the CLASSLIB is
hardcoded into build.xml
Posted by "Geir Magnusson Jr (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-981?page=all ]
Geir Magnusson Jr closed HARMONY-981.
-------------------------------------
> [drlvm][build] link to the CLASSLIB is hardcoded into build.xml
> ---------------------------------------------------------------
>
> Key: HARMONY-981
> URL: http://issues.apache.org/jira/browse/HARMONY-981
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Vladimir Ivanov
> Assigned To: Geir Magnusson Jr
>
> link to the CLASSLIB is hardcoded into build.xml (line 65) as
> <property name="external.dep.CLASSLIB.loc" value="../../../../classlib/trunk" />
> instead of use the predefined property from property file. Something like that:
> <property name="external.dep.CLASSLIB.loc" value="${CLASSLIB_HOME}" />
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-981) [drlvm][build] link to the CLASSLIB
is hardcoded into build.xml
Posted by "Salikh Zakirov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-981?page=comments#action_12424890 ]
Salikh Zakirov commented on HARMONY-981:
----------------------------------------
The property is not "hardcoded" in build.xml per se.
You can always override the default value by running
build.bat -Dexternal.dep.CLASSLIB=.../
And if you want to do environment reading, then the code like below can serve you
<property environment="env"/>
<condition property="external.dep.CLASSLIB.loc" value="${env.CLASSLIB_HOME}">
<isset property="env.CLASSLIB_HOME"/>
</condition>
<available property="classlib.okay" file="${external.dep.CLASSLIB.loc}/lib/boot/luni.jar"/>
<fail unless="classlib.okay">Error:
Can't find Harmony class library.
Please set the environment variable CLASSLIB_HOME
or pass the classlib locations as -Dexternal.dep.CLASSLIB.loc=...
</fail>
(* untested *).
Feel free to submit the above as patch if you feel the urge.
> [drlvm][build] link to the CLASSLIB is hardcoded into build.xml
> ---------------------------------------------------------------
>
> Key: HARMONY-981
> URL: http://issues.apache.org/jira/browse/HARMONY-981
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Vladimir Ivanov
>
> link to the CLASSLIB is hardcoded into build.xml (line 65) as
> <property name="external.dep.CLASSLIB.loc" value="../../../../classlib/trunk" />
> instead of use the predefined property from property file. Something like that:
> <property name="external.dep.CLASSLIB.loc" value="${CLASSLIB_HOME}" />
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira