You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/05/09 08:51:48 UTC
[GitHub] [incubator-doris] jackwener opened a new pull request, #9470: [refactor](Nereids): small refactor
jackwener opened a new pull request, #9470:
URL: https://github.com/apache/incubator-doris/pull/9470
# Proposed changes
Issue Number: close #xxx
## Problem Summary:
Describe the overview of changes.
- rename GroupExpression
- use `HashSet<GroupExpression> groupExpressions` in `memo`
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9470: [refactor](Nereids): refactor
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9470:
URL: https://github.com/apache/incubator-doris/pull/9470#issuecomment-1123131035
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 merged pull request #9470: [refactor](Nereids): refactor
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 merged PR #9470:
URL: https://github.com/apache/incubator-doris/pull/9470
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] wangshuo128 commented on a diff in pull request #9470: [refactor](Nereids): small refactor
Posted by GitBox <gi...@apache.org>.
wangshuo128 commented on code in PR #9470:
URL: https://github.com/apache/incubator-doris/pull/9470#discussion_r867792476
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/memo/Memo.java:
##########
@@ -21,19 +21,21 @@
import org.apache.doris.nereids.trees.plans.logical.LogicalPlan;
import com.google.common.collect.Lists;
+import org.glassfish.jersey.internal.guava.Sets;
+import java.util.HashSet;
import java.util.List;
/**
* Representation for memo in cascades optimizer.
*/
public class Memo {
private final List<Group> groups = Lists.newArrayList();
- private final List<PlanReference> planReferences = Lists.newArrayList();
+ private final HashSet<GroupExpression> groupExpressions = Sets.newHashSet();
Review Comment:
```suggestion
private final Set<GroupExpression> groupExpressions = Sets.newHashSet();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] jackwener commented on pull request #9470: [refactor](Nereids): small refactor
Posted by GitBox <gi...@apache.org>.
jackwener commented on PR #9470:
URL: https://github.com/apache/incubator-doris/pull/9470#issuecomment-1121025350
PTAL @morningman @EmmyMiao87
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9470: [refactor](Nereids): refactor
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9470:
URL: https://github.com/apache/incubator-doris/pull/9470#issuecomment-1123131010
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org