You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/09/10 05:26:27 UTC

[GitHub] [shardingsphere] Lychengit opened a new issue #12333: Case can be ignored here

Lychengit opened a new issue #12333:
URL: https://github.com/apache/shardingsphere/issues/12333


   ShardingRule::
   private boolean isShardingColumn(final ShardingStrategyConfiguration shardingStrategyConfig, final String columnName) {
       ... ...
       // Case can be ignored here，May cause all tables to be manipulated！Insert statement encountered. All tables were inserted
       return ((ComplexShardingStrategyConfiguration) shardingStrategyConfig).getShardingColumns().contains(columnName);
   }


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang edited a comment on issue #12333: ignore case

Posted by GitBox <gi...@apache.org>.
RaigorJiang edited a comment on issue #12333:
URL: https://github.com/apache/shardingsphere/issues/12333#issuecomment-919868747


   > @yx9o @strongduanmu I may have another problem.
   > No error prompt for duplicate unique values. like this. The id field is the primary key. Insert ID 123 at the same time, No error.
   
   This was fixed in master branch.  https://github.com/apache/shardingsphere/issues/10138


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] yx9o edited a comment on issue #12333: ignore case

Posted by GitBox <gi...@apache.org>.
yx9o edited a comment on issue #12333:
URL: https://github.com/apache/shardingsphere/issues/12333#issuecomment-919702842


   > Thanks @Lychengit
   > @yx9o Hi, are you interested in this issue? Firstly let us check whether @Lychengit 's description exists. If so, fix it. ;-)
   
   @tristaZero @strongduanmu @Lychengit Hi, I verified it on the master branch, and the result is consistent with the description of @Lychengit.
   ![image](https://user-images.githubusercontent.com/12792261/133374009-1807e845-d2db-49e2-99f4-20e32e1ec065.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] Lychengit commented on issue #12333: ignore case

Posted by GitBox <gi...@apache.org>.
Lychengit commented on issue #12333:
URL: https://github.com/apache/shardingsphere/issues/12333#issuecomment-919682150


   @yx9o @strongduanmu The CONVERTID fields in SQL should be capitalized. But the parsed fields are lowercase. like columnName at the breakpoint.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on issue #12333: ignore case

Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #12333:
URL: https://github.com/apache/shardingsphere/issues/12333#issuecomment-919673882


   Thanks @Lychengit 
   @yx9o Hi, are you interested in this issue? Firstly let us check whether @Lychengit 's description exists. If so, fix it. ;-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] strongduanmu commented on issue #12333: ignore case

Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #12333:
URL: https://github.com/apache/shardingsphere/issues/12333#issuecomment-919677151


   @yx9o Can you help check weather exists case problem in `ComplexShardingStrategyConfiguration`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] Lychengit commented on issue #12333: ignore case

Posted by GitBox <gi...@apache.org>.
Lychengit commented on issue #12333:
URL: https://github.com/apache/shardingsphere/issues/12333#issuecomment-919680381


   @yx9o @strongduanmu 
   （5.0.0-beta）If the field is capitalized, it may cause all tables to be inserted. The master branch has not been tried yet. This is my test configuration, and what I saw at the breakpoint. （Although table field capitalization is not standardized.）
   ![image](https://user-images.githubusercontent.com/90435449/133368228-c93f633c-392d-4901-963a-4932b9c3324b.png)
   ![image](https://user-images.githubusercontent.com/90435449/133368249-a90b5a93-bc9f-4726-a74a-2431a0f9f953.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] Lychengit commented on issue #12333: ignore case

Posted by GitBox <gi...@apache.org>.
Lychengit commented on issue #12333:
URL: https://github.com/apache/shardingsphere/issues/12333#issuecomment-919742999


   @yx9o @strongduanmu I may have another problem.
    No error prompt for duplicate unique values. like this. The id field is the primary key. Insert ID 123 at the same time, No error.
   ![image](https://user-images.githubusercontent.com/90435449/133383207-9d087539-b82a-401e-8116-26a90296712b.png)
   ![image](https://user-images.githubusercontent.com/90435449/133383238-96fa49e7-b1bb-4797-acb2-d31000f28da7.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] yx9o commented on issue #12333: ignore case

Posted by GitBox <gi...@apache.org>.
yx9o commented on issue #12333:
URL: https://github.com/apache/shardingsphere/issues/12333#issuecomment-916661146


   Please assign to me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on issue #12333: ignore case

Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #12333:
URL: https://github.com/apache/shardingsphere/issues/12333#issuecomment-919673994


   Could you give some pointers to @yx9o ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] Lychengit closed issue #12333: ignore case

Posted by GitBox <gi...@apache.org>.
Lychengit closed issue #12333:
URL: https://github.com/apache/shardingsphere/issues/12333


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on issue #12333: ignore case

Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #12333:
URL: https://github.com/apache/shardingsphere/issues/12333#issuecomment-917594746


   Hi which version does this issue mention? @Lychengit 
   @yx9o Sure, welcome.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] yx9o commented on issue #12333: ignore case

Posted by GitBox <gi...@apache.org>.
yx9o commented on issue #12333:
URL: https://github.com/apache/shardingsphere/issues/12333#issuecomment-919736070


   > Hi @Lychengit , you can look at the source of lowercase tableName and submit a PR to fix this problem.
   
   @strongduanmu Hi, I found the place where columnName changed to lowercase.
   ![image](https://user-images.githubusercontent.com/12792261/133381494-433ae81c-f919-44a1-b81f-4a22dd94b2c6.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] strongduanmu commented on issue #12333: ignore case

Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #12333:
URL: https://github.com/apache/shardingsphere/issues/12333#issuecomment-919676736


   @Lychengit @yx9o Can you try the master branch? PR #11750 added some checks to prevent full routing of insert statements.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] yx9o commented on issue #12333: ignore case

Posted by GitBox <gi...@apache.org>.
yx9o commented on issue #12333:
URL: https://github.com/apache/shardingsphere/issues/12333#issuecomment-919702842


   > Thanks @Lychengit
   > @yx9o Hi, are you interested in this issue? Firstly let us check whether @Lychengit 's description exists. If so, fix it. ;-)
   
   @tristaZero @strongduanmu @Lychengit Hi, I verified it on the master branch, and the result is consistent with the description of @Lychengit.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang commented on issue #12333: ignore case

Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on issue #12333:
URL: https://github.com/apache/shardingsphere/issues/12333#issuecomment-919875583


   > > @yx9o @strongduanmu I may have another problem.
   > > No error prompt for duplicate unique values. like this. The id field is the primary key. Insert ID 123 at the same time, No error.
   > 
   > This was fixed in master branch. #10138
   
   Hi @Lychengit 
   I just mean the issue of exception was not thrown. Not about the case problem.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] Lychengit commented on issue #12333: ignore case

Posted by GitBox <gi...@apache.org>.
Lychengit commented on issue #12333:
URL: https://github.com/apache/shardingsphere/issues/12333#issuecomment-919871514


   @yx9o @RaigorJiang @strongduanmu 
   Thanks, I appreciate your hard work.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang commented on issue #12333: ignore case

Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on issue #12333:
URL: https://github.com/apache/shardingsphere/issues/12333#issuecomment-919868747


   > @yx9o @strongduanmu I may have another problem.
   > No error prompt for duplicate unique values. like this. The id field is the primary key. Insert ID 123 at the same time, No error.
   
   This was fixed in master branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] Lychengit commented on issue #12333: ignore case

Posted by GitBox <gi...@apache.org>.
Lychengit commented on issue #12333:
URL: https://github.com/apache/shardingsphere/issues/12333#issuecomment-917610973


   @tristaZero 5.0.0-beta


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero edited a comment on issue #12333: ignore case

Posted by GitBox <gi...@apache.org>.
tristaZero edited a comment on issue #12333:
URL: https://github.com/apache/shardingsphere/issues/12333#issuecomment-919673994


   @strongduanmu  Could you give some pointers to @yx9o ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] Lychengit commented on issue #12333: ignore case

Posted by GitBox <gi...@apache.org>.
Lychengit commented on issue #12333:
URL: https://github.com/apache/shardingsphere/issues/12333#issuecomment-919744912


   @yx9o @strongduanmu Normal exceptions should report errors and primary key conflicts.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] strongduanmu commented on issue #12333: ignore case

Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #12333:
URL: https://github.com/apache/shardingsphere/issues/12333#issuecomment-919683199


   Hi @Lychengit , you can look at the source of lowercase tableName and submit a PR to fix this problem.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org