[GitHub] [incubator-superset] graceguo-supercat commented on a change in pull request #10962: [WIP] fix: cypress dashboard edit mode test

[GitBox <gi...@apache.org>]

graceguo-supercat commented on a change in pull request #10962:
URL: https://github.com/apache/incubator-superset/pull/10962#discussion_r491220432



##########
File path: superset-frontend/cypress-base/cypress/integration/dashboard/edit_mode.test.js
##########
@@ -23,34 +23,35 @@ describe('Dashboard edit mode', () => {
     cy.server();
     cy.login();
     cy.visit(WORLD_HEALTH_DASHBOARD);
+    cy.route('POST', '/superset/explore_json/*?dashboard_id=1').as('worldMap');
     cy.get('.dashboard-header [data-test=pencil]').click();
   });
 
   it('remove, and add chart flow', () => {
-    // wait for box plot to appear
-    cy.get('.grid-container .box_plot');
-
-    cy.get('.fa.fa-trash')
-      .last()
+    // wait for world map to appear
+    cy.wait('@worldMap');
+    cy.get('.world_map', { timeout: 60000 })

Review comment:
       I do not think the flaky problem is caused by `box_plot` chart




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org