You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "step-security-bot (via GitHub)" <gi...@apache.org> on 2023/11/09 12:25:45 UTC

[PR] [StepSecurity] ci: Harden GitHub Actions [cloudstack]

step-security-bot opened a new pull request, #8209:
URL: https://github.com/apache/cloudstack/pull/8209

   ## Summary
   
   This pull request is created by [StepSecurity](https://app.stepsecurity.io/securerepo) at the request of @jbampton. Please merge the Pull Request to incorporate the requested changes. Please tag @jbampton on your message if you have any questions related to the PR.
   ## Security Fixes
   
   ### Least Privileged GitHub Actions Token Permissions
   
   The GITHUB_TOKEN is an automatically generated secret to make authenticated calls to the GitHub API. GitHub recommends setting minimum token permissions for the GITHUB_TOKEN.
   
   - [GitHub Security Guide](https://docs.github.com/en/actions/security-guides/automatic-token-authentication#using-the-github_token-in-a-workflow)
   - [The Open Source Security Foundation (OpenSSF) Security Guide](https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions)
   
   
   ## Feedback
   For bug reports, feature requests, and general feedback; please email support@stepsecurity.io. To create such PRs, please visit https://app.stepsecurity.io/securerepo.
   
   
   Signed-off-by: StepSecurity Bot <bo...@stepsecurity.io>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [StepSecurity] ci: Harden GitHub Actions [cloudstack]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #8209:
URL: https://github.com/apache/cloudstack/pull/8209#issuecomment-1803749452

   ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8209?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#8209](https://app.codecov.io/gh/apache/cloudstack/pull/8209?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (3fef2dc) into [main](https://app.codecov.io/gh/apache/cloudstack/commit/29a223bf9b75bf62099c227b95d75cae65a1cf62?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (29a223b) will **decrease** coverage by `24.63%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@             Coverage Diff              @@
   ##               main   #8209       +/-   ##
   ============================================
   - Coverage     29.12%   4.50%   -24.63%     
   ============================================
     Files          5186     354     -4832     
     Lines        365754   27872   -337882     
     Branches      53489    4868    -48621     
   ============================================
   - Hits         106518    1255   -105263     
   + Misses       244628   26479   -218149     
   + Partials      14608     138    -14470     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8209/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [simulator-marvin-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8209/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/8209/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.50% <ø> (ø)` | |
   | [unit-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8209/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   [see 4832 files with indirect coverage changes](https://app.codecov.io/gh/apache/cloudstack/pull/8209/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in [Chrome](https://chrome.google.com/webstore/detail/codecov/gedikamndpbemklijjkncpnolildpbgo) or [Firefox](https://addons.mozilla.org/en-US/firefox/addon/codecov/) today!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [StepSecurity] ci: Harden GitHub Actions [cloudstack]

Posted by "jbampton (via GitHub)" <gi...@apache.org>.
jbampton commented on PR #8209:
URL: https://github.com/apache/cloudstack/pull/8209#issuecomment-1803951519

   Previous prs have read access to many in there workflows.  For example:
   
   https://github.com/apache/cloudstack/actions/runs/6810677707/job/18519674655?pr=8207
   
   ![Screenshot from 2023-11-10 00-29-12](https://github.com/apache/cloudstack/assets/418747/48194e9f-6f1f-4e51-b6cb-6105a32f34e1)
   
   This pr restricts the read access to only two:
   
   https://github.com/apache/cloudstack/actions/runs/6811742644/job/18522765921?pr=8209
   
   ![Screenshot from 2023-11-10 00-29-32](https://github.com/apache/cloudstack/assets/418747/5eb48c9d-ae0f-4173-af7f-4e46c6218ee1)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [StepSecurity] ci: Harden GitHub Actions [cloudstack]

Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud merged PR #8209:
URL: https://github.com/apache/cloudstack/pull/8209


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org