You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@manifoldcf.apache.org by "Luca Stancapiano (Created) (JIRA)" <ji...@apache.org> on 2012/02/18 19:25:59 UTC
[jira] [Created] (CONNECTORS-412) Velocity params in Open Search
Server Connector
Velocity params in Open Search Server Connector
-----------------------------------------------
Key: CONNECTORS-412
URL: https://issues.apache.org/jira/browse/CONNECTORS-412
Project: ManifoldCF
Issue Type: Improvement
Components: OpenSearchServer connector
Affects Versions: ManifoldCF 0.5
Environment: velocity
Reporter: Luca Stancapiano
Fix For: ManifoldCF 0.5
I see opensearchserver is the last connector that uses the custom script in the html pages. I updated it with velocity as for the other project.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-412) Velocity params in Open Search
Server Connector
Posted by "Luca Stancapiano (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONNECTORS-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211187#comment-13211187 ]
Luca Stancapiano commented on CONNECTORS-412:
---------------------------------------------
sorry...I didn't understand... should I do something about it?
> Velocity params in Open Search Server Connector
> -----------------------------------------------
>
> Key: CONNECTORS-412
> URL: https://issues.apache.org/jira/browse/CONNECTORS-412
> Project: ManifoldCF
> Issue Type: Improvement
> Components: OpenSearchServer connector
> Affects Versions: ManifoldCF 0.5
> Environment: velocity
> Reporter: Luca Stancapiano
> Assignee: Karl Wright
> Labels: opensearchserver, velocity
> Fix For: ManifoldCF 0.5
>
> Attachments: manifold-opensearchserver-velocity-patch, manifold-opensearchserver-velocity-patch
>
>
> I see opensearchserver is the last connector that uses the custom script in the html pages instead of velocity. I updated it with velocity as for the other projects.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-412) Velocity params in Open Search
Server Connector
Posted by "Karl Wright (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONNECTORS-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211096#comment-13211096 ]
Karl Wright commented on CONNECTORS-412:
----------------------------------------
Ok, you have correct the problem in question, and I will commit the patch. But do you also notice something else wrong with the same code?
Specifically:
... value="$MIMETYPES_B" ...
should be:
... value="$MIMETYPES_A" ...
because the value in attribute should be properly encoded for the attribute, not for html body.
If you want to attach an additional patch fixing this problem (looks like it is only in the hiddens) I'd be happy to commit that too.
> Velocity params in Open Search Server Connector
> -----------------------------------------------
>
> Key: CONNECTORS-412
> URL: https://issues.apache.org/jira/browse/CONNECTORS-412
> Project: ManifoldCF
> Issue Type: Improvement
> Components: OpenSearchServer connector
> Affects Versions: ManifoldCF 0.5
> Environment: velocity
> Reporter: Luca Stancapiano
> Labels: opensearchserver, velocity
> Fix For: ManifoldCF 0.5
>
> Attachments: manifold-opensearchserver-velocity-patch, manifold-opensearchserver-velocity-patch
>
>
> I see opensearchserver is the last connector that uses the custom script in the html pages instead of velocity. I updated it with velocity as for the other projects.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (CONNECTORS-412) Velocity params in Open Search
Server Connector
Posted by "Karl Wright (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONNECTORS-412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Karl Wright reassigned CONNECTORS-412:
--------------------------------------
Assignee: Karl Wright
> Velocity params in Open Search Server Connector
> -----------------------------------------------
>
> Key: CONNECTORS-412
> URL: https://issues.apache.org/jira/browse/CONNECTORS-412
> Project: ManifoldCF
> Issue Type: Improvement
> Components: OpenSearchServer connector
> Affects Versions: ManifoldCF 0.5
> Environment: velocity
> Reporter: Luca Stancapiano
> Assignee: Karl Wright
> Labels: opensearchserver, velocity
> Fix For: ManifoldCF 0.5
>
> Attachments: manifold-opensearchserver-velocity-patch, manifold-opensearchserver-velocity-patch
>
>
> I see opensearchserver is the last connector that uses the custom script in the html pages instead of velocity. I updated it with velocity as for the other projects.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-412) Velocity params in Open Search
Server Connector
Posted by "Karl Wright (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONNECTORS-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211295#comment-13211295 ]
Karl Wright commented on CONNECTORS-412:
----------------------------------------
It is a different problem that was already there in the code. I will open a different ticket for it.
> Velocity params in Open Search Server Connector
> -----------------------------------------------
>
> Key: CONNECTORS-412
> URL: https://issues.apache.org/jira/browse/CONNECTORS-412
> Project: ManifoldCF
> Issue Type: Improvement
> Components: OpenSearchServer connector
> Affects Versions: ManifoldCF 0.5
> Environment: velocity
> Reporter: Luca Stancapiano
> Assignee: Karl Wright
> Labels: opensearchserver, velocity
> Fix For: ManifoldCF 0.5
>
> Attachments: manifold-opensearchserver-velocity-patch, manifold-opensearchserver-velocity-patch
>
>
> I see opensearchserver is the last connector that uses the custom script in the html pages instead of velocity. I updated it with velocity as for the other projects.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-412) Velocity params in Open Search
Server Connector
Posted by "Karl Wright (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONNECTORS-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211119#comment-13211119 ]
Karl Wright commented on CONNECTORS-412:
----------------------------------------
r1290889 for the current patch.
> Velocity params in Open Search Server Connector
> -----------------------------------------------
>
> Key: CONNECTORS-412
> URL: https://issues.apache.org/jira/browse/CONNECTORS-412
> Project: ManifoldCF
> Issue Type: Improvement
> Components: OpenSearchServer connector
> Affects Versions: ManifoldCF 0.5
> Environment: velocity
> Reporter: Luca Stancapiano
> Assignee: Karl Wright
> Labels: opensearchserver, velocity
> Fix For: ManifoldCF 0.5
>
> Attachments: manifold-opensearchserver-velocity-patch, manifold-opensearchserver-velocity-patch
>
>
> I see opensearchserver is the last connector that uses the custom script in the html pages instead of velocity. I updated it with velocity as for the other projects.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CONNECTORS-412) Velocity params in Open Search
Server Connector
Posted by "Luca Stancapiano (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONNECTORS-412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Luca Stancapiano updated CONNECTORS-412:
----------------------------------------
Description: I see opensearchserver is the last connector that uses the custom script in the html pages instead of velocity. I updated it with velocity as for the other projects. (was: I see opensearchserver is the last connector that uses the custom script in the html pages. I updated it with velocity as for the other project.)
> Velocity params in Open Search Server Connector
> -----------------------------------------------
>
> Key: CONNECTORS-412
> URL: https://issues.apache.org/jira/browse/CONNECTORS-412
> Project: ManifoldCF
> Issue Type: Improvement
> Components: OpenSearchServer connector
> Affects Versions: ManifoldCF 0.5
> Environment: velocity
> Reporter: Luca Stancapiano
> Labels: opensearchserver, velocity
> Fix For: ManifoldCF 0.5
>
> Attachments: manifold-opensearchserver-velocity-patch
>
>
> I see opensearchserver is the last connector that uses the custom script in the html pages instead of velocity. I updated it with velocity as for the other projects.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CONNECTORS-412) Velocity params in Open Search
Server Connector
Posted by "Karl Wright (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONNECTORS-412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Karl Wright updated CONNECTORS-412:
-----------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Velocity params in Open Search Server Connector
> -----------------------------------------------
>
> Key: CONNECTORS-412
> URL: https://issues.apache.org/jira/browse/CONNECTORS-412
> Project: ManifoldCF
> Issue Type: Improvement
> Components: OpenSearchServer connector
> Affects Versions: ManifoldCF 0.5
> Environment: velocity
> Reporter: Luca Stancapiano
> Assignee: Karl Wright
> Labels: opensearchserver, velocity
> Fix For: ManifoldCF 0.5
>
> Attachments: manifold-opensearchserver-velocity-patch, manifold-opensearchserver-velocity-patch
>
>
> I see opensearchserver is the last connector that uses the custom script in the html pages instead of velocity. I updated it with velocity as for the other projects.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-412) Velocity params in Open Search
Server Connector
Posted by "Karl Wright (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONNECTORS-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211052#comment-13211052 ]
Karl Wright commented on CONNECTORS-412:
----------------------------------------
This does not look correct:
--- connectors/opensearchserver/connector/src/main/resources/org/apache/manifoldcf/agents/output/opensearchserver/hiddenSpecification_ja_JP.html (revision 1290829)
+++ connectors/opensearchserver/connector/src/main/resources/org/apache/manifoldcf/agents/output/opensearchserver/hiddenSpecification_ja_JP.html (working copy)
@@ -14,6 +14,6 @@
See the License for the specific language governing permissions and
limitations under the License.
-->
-<input type="hidden" name="maxfilesize" value="${MAXFILESIZE:A}" />
-<input type="hidden" name="mimetypes" value="${MIMETYPES:B}" />
-<input type="hidden" name="extensions" value="${EXTENSIONS:B}" />
\ No newline at end of file
+<input type="hidden" name="maxfilesize" value="$_MAXFILESIZE_A" />
+<input type="hidden" name="mimetypes" value="$_MIMETYPES_B" />
+<input type="hidden" name="extensions" value="$_EXTENSIONS_B" />
\ No newline at end of file
Note the leading underscore in the variable names...
> Velocity params in Open Search Server Connector
> -----------------------------------------------
>
> Key: CONNECTORS-412
> URL: https://issues.apache.org/jira/browse/CONNECTORS-412
> Project: ManifoldCF
> Issue Type: Improvement
> Components: OpenSearchServer connector
> Affects Versions: ManifoldCF 0.5
> Environment: velocity
> Reporter: Luca Stancapiano
> Labels: opensearchserver, velocity
> Fix For: ManifoldCF 0.5
>
> Attachments: manifold-opensearchserver-velocity-patch
>
>
> I see opensearchserver is the last connector that uses the custom script in the html pages instead of velocity. I updated it with velocity as for the other projects.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CONNECTORS-412) Velocity params in Open Search
Server Connector
Posted by "Luca Stancapiano (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONNECTORS-412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Luca Stancapiano updated CONNECTORS-412:
----------------------------------------
Attachment: manifold-opensearchserver-velocity-patch
> Velocity params in Open Search Server Connector
> -----------------------------------------------
>
> Key: CONNECTORS-412
> URL: https://issues.apache.org/jira/browse/CONNECTORS-412
> Project: ManifoldCF
> Issue Type: Improvement
> Components: OpenSearchServer connector
> Affects Versions: ManifoldCF 0.5
> Environment: velocity
> Reporter: Luca Stancapiano
> Labels: opensearchserver, velocity
> Fix For: ManifoldCF 0.5
>
> Attachments: manifold-opensearchserver-velocity-patch
>
>
> I see opensearchserver is the last connector that uses the custom script in the html pages. I updated it with velocity as for the other project.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CONNECTORS-412) Velocity params in Open Search
Server Connector
Posted by "Luca Stancapiano (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONNECTORS-412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Luca Stancapiano updated CONNECTORS-412:
----------------------------------------
Labels: opensearchserver velocity (was: )
Status: Patch Available (was: Open)
Here the patch
> Velocity params in Open Search Server Connector
> -----------------------------------------------
>
> Key: CONNECTORS-412
> URL: https://issues.apache.org/jira/browse/CONNECTORS-412
> Project: ManifoldCF
> Issue Type: Improvement
> Components: OpenSearchServer connector
> Affects Versions: ManifoldCF 0.5
> Environment: velocity
> Reporter: Luca Stancapiano
> Labels: velocity, opensearchserver
> Fix For: ManifoldCF 0.5
>
>
> I see opensearchserver is the last connector that uses the custom script in the html pages. I updated it with velocity as for the other project.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-412) Velocity params in Open Search
Server Connector
Posted by "Karl Wright (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONNECTORS-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211300#comment-13211300 ]
Karl Wright commented on CONNECTORS-412:
----------------------------------------
The new ticket is CONNECTORS-413. I committed a fix for it too.
> Velocity params in Open Search Server Connector
> -----------------------------------------------
>
> Key: CONNECTORS-412
> URL: https://issues.apache.org/jira/browse/CONNECTORS-412
> Project: ManifoldCF
> Issue Type: Improvement
> Components: OpenSearchServer connector
> Affects Versions: ManifoldCF 0.5
> Environment: velocity
> Reporter: Luca Stancapiano
> Assignee: Karl Wright
> Labels: opensearchserver, velocity
> Fix For: ManifoldCF 0.5
>
> Attachments: manifold-opensearchserver-velocity-patch, manifold-opensearchserver-velocity-patch
>
>
> I see opensearchserver is the last connector that uses the custom script in the html pages instead of velocity. I updated it with velocity as for the other projects.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CONNECTORS-412) Velocity params in Open Search
Server Connector
Posted by "Luca Stancapiano (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONNECTORS-412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Luca Stancapiano updated CONNECTORS-412:
----------------------------------------
Attachment: manifold-opensearchserver-velocity-patch
yes sorry......here the corrected patch
> Velocity params in Open Search Server Connector
> -----------------------------------------------
>
> Key: CONNECTORS-412
> URL: https://issues.apache.org/jira/browse/CONNECTORS-412
> Project: ManifoldCF
> Issue Type: Improvement
> Components: OpenSearchServer connector
> Affects Versions: ManifoldCF 0.5
> Environment: velocity
> Reporter: Luca Stancapiano
> Labels: opensearchserver, velocity
> Fix For: ManifoldCF 0.5
>
> Attachments: manifold-opensearchserver-velocity-patch, manifold-opensearchserver-velocity-patch
>
>
> I see opensearchserver is the last connector that uses the custom script in the html pages instead of velocity. I updated it with velocity as for the other projects.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira