You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/02/11 08:14:42 UTC
[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2347: LUCENE-9760: Hunspell: print total memory usage in TestAllDictionarie…
donnerpeter commented on a change in pull request #2347:
URL: https://github.com/apache/lucene-solr/pull/2347#discussion_r574311027
##########
File path: lucene/analysis/common/src/test/org/apache/lucene/analysis/hunspell/TestAllDictionaries.java
##########
@@ -181,11 +188,16 @@ public void testDictionariesLoadSuccessfully() throws Exception {
}
} finally {
executor.shutdown();
- executor.awaitTermination(1, TimeUnit.MINUTES);
+ assertTrue(executor.awaitTermination(1, TimeUnit.MINUTES));
Review comment:
This was yellow-highlighted by the IDE, and it was easier to surrender :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org