You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ian Downes <ia...@gmail.com> on 2015/01/26 23:44:09 UTC
Review Request 30290: Remove deprecated slave flag
--cgroups_subsystems.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30290/
-----------------------------------------------------------
Review request for mesos and Dominic Hamon.
Bugs: MESOS-2184
https://issues.apache.org/jira/browse/MESOS-2184
Repository: mesos-git
Description
-------
Remove deprecated slave flag --cgroups_subsystems.
Diffs
-----
docs/configuration.md 8a55f631b7cabcc075cb496d70de87384fa79eae
src/slave/flags.hpp a3c5c68a553b1c88ce6d5177e625079f7cdb2e5f
Diff: https://reviews.apache.org/r/30290/diff/
Testing
-------
Thanks,
Ian Downes
Re: Review Request 30290: Remove deprecated slave flag
--cgroups_subsystems.
Posted by Ian Downes <ia...@gmail.com>.
> On Jan. 26, 2015, 2:51 p.m., Dominic Hamon wrote:
> > please also add to the CHANGELOG for 0.22. see https://reviews.apache.org/r/30288/ for example.
Was already added to docs/upgrades.md at 0.18.0.
- Ian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30290/#review69690
-----------------------------------------------------------
On Jan. 26, 2015, 2:44 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30290/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2015, 2:44 p.m.)
>
>
> Review request for mesos and Dominic Hamon.
>
>
> Bugs: MESOS-2184
> https://issues.apache.org/jira/browse/MESOS-2184
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Remove deprecated slave flag --cgroups_subsystems.
>
>
> Diffs
> -----
>
> docs/configuration.md 8a55f631b7cabcc075cb496d70de87384fa79eae
> src/slave/flags.hpp a3c5c68a553b1c88ce6d5177e625079f7cdb2e5f
>
> Diff: https://reviews.apache.org/r/30290/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 30290: Remove deprecated slave flag
--cgroups_subsystems.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30290/#review69690
-----------------------------------------------------------
please also add to the CHANGELOG for 0.22. see https://reviews.apache.org/r/30288/ for example.
- Dominic Hamon
On Jan. 26, 2015, 2:44 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30290/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2015, 2:44 p.m.)
>
>
> Review request for mesos and Dominic Hamon.
>
>
> Bugs: MESOS-2184
> https://issues.apache.org/jira/browse/MESOS-2184
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Remove deprecated slave flag --cgroups_subsystems.
>
>
> Diffs
> -----
>
> docs/configuration.md 8a55f631b7cabcc075cb496d70de87384fa79eae
> src/slave/flags.hpp a3c5c68a553b1c88ce6d5177e625079f7cdb2e5f
>
> Diff: https://reviews.apache.org/r/30290/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 30290: Remove deprecated slave flag
--cgroups_subsystems.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30290/#review69691
-----------------------------------------------------------
Ship it!
Ship It!
- Dominic Hamon
On Jan. 26, 2015, 2:44 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30290/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2015, 2:44 p.m.)
>
>
> Review request for mesos and Dominic Hamon.
>
>
> Bugs: MESOS-2184
> https://issues.apache.org/jira/browse/MESOS-2184
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Remove deprecated slave flag --cgroups_subsystems.
>
>
> Diffs
> -----
>
> docs/configuration.md 8a55f631b7cabcc075cb496d70de87384fa79eae
> src/slave/flags.hpp a3c5c68a553b1c88ce6d5177e625079f7cdb2e5f
>
> Diff: https://reviews.apache.org/r/30290/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 30290: Remove deprecated slave flag
--cgroups_subsystems.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30290/#review69708
-----------------------------------------------------------
Bad patch!
Reviews applied: [30290]
Failed command: ./support/apply-review.sh -n -r 30290
Error:
2015-01-27 00:23:22 URL:https://reviews.apache.org/r/30290/diff/raw/ [1417/1417] -> "30290.patch" [1]
error: patch failed: docs/configuration.md:684
error: docs/configuration.md: patch does not apply
error: patch failed: src/slave/flags.hpp:219
error: src/slave/flags.hpp: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On Jan. 26, 2015, 10:44 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30290/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2015, 10:44 p.m.)
>
>
> Review request for mesos and Dominic Hamon.
>
>
> Bugs: MESOS-2184
> https://issues.apache.org/jira/browse/MESOS-2184
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Remove deprecated slave flag --cgroups_subsystems.
>
>
> Diffs
> -----
>
> docs/configuration.md 8a55f631b7cabcc075cb496d70de87384fa79eae
> src/slave/flags.hpp a3c5c68a553b1c88ce6d5177e625079f7cdb2e5f
>
> Diff: https://reviews.apache.org/r/30290/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ian Downes
>
>