You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by GitBox <gi...@apache.org> on 2022/04/19 19:02:24 UTC

[GitHub] [cxf] ffang commented on a diff in pull request #937: [CXF-8695]:Remove duplicate copied class from cxf-core in cxf-rt-mana…

ffang commented on code in PR #937:
URL: https://github.com/apache/cxf/pull/937#discussion_r853395945


##########
rt/management/pom.xml:
##########
@@ -156,18 +156,6 @@
                             </execution>
                         </executions>
                     </plugin>
-                    <plugin>

Review Comment:
   Hi @jimma ,
   
   Please change as this way
   ```
   <configuration>
                                <obrRepository>NONE</obrRepository>
                                <instructions>
   -                                <Export-Package>org.apache.cxf.management*,org.apache.cxf.tracing*</Export-Package>
   +                                <Export-Package>
   +                                                org.apache.cxf.management.counters,
   +                                                org.apache.cxf.management.interceptor,
   +                                                org.apache.cxf.management.persistence,
   +                                                org.apache.cxf.management.utils,
   +                                                org.apache.cxf.management.jmx,
   +                                                org.apache.cxf.management.jmx.export.runtime,
   +                                                org.apache.cxf.tracing*
   +                                </Export-Package>
                                </instructions>
                                <niceManifest>true</niceManifest>
                            </configuration>
   ```
   
   The root cause of this issue is that the previous org.apache.cxf.management* isn't specific enough, it include package from core, we should use the more fine-grained export package of cxf-rt-management module to avoid it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org