You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/07/10 09:59:11 UTC
[GitHub] [cloudstack] Spaceman1984 opened a new pull request #4207: Human readable sizes in logs
Spaceman1984 opened a new pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207
## Description
<!--- Describe your changes in detail -->
This PR adds a global variable which will control outputting human readable byte sizes in logs.
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
This is largely untested, testing is still to be done
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-670787276
<b>Trillian test result (tid-2294)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 50425 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4207-t2294-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 81 look OK, 3 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_reset_vm_on_reboot | `Error` | 7.25 | test_reset_vm_on_reboot.py
test_04_rvpc_network_garbage_collector_nics | `Error` | 3811.18 | test_vpc_redundant.py
test_hostha_kvm_host_fencing | `Error` | 370.82 | test_hostha_kvm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#discussion_r460814967
##########
File path: core/src/main/java/com/cloud/agent/transport/Request.java
##########
@@ -395,7 +396,7 @@ public String toString() {
return log("", true, Level.DEBUG);
}
- protected String log(String msg, boolean logContent, Level level) {
+ protected String log(String msg, boolean logContent, Level level) {
Review comment:
extra space
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-670256690
<b>Trillian test result (tid-2278)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 49892 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4207-t2278-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 77 look OK, 3 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_add_delete_kubernetes_supported_version | `Error` | 1807.80 | test_kubernetes_supported_versions.py
test_11_migrate_vm | `Error` | 61.06 | test_vm_life_cycle.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 478.83 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | `Error` | 3799.13 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | `Error` | 3799.16 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Error` | 0.01 | test_vpc_redundant.py
ContextSuite context=TestVPCRedundancy>:teardown | `Error` | 0.01 | test_vpc_redundant.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-670384047
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-663045962
Packaging result: ✔centos7 ✔debian. JID-1599
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-668518765
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-668498180
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-669771901
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-665472945
@Spaceman1984 failures related to vm lifecycle seen here as well, I suspect it may be related to the fix you added in #4226
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-668519294
@Spaceman1984 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-671864568
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-663031016
@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-658087586
@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-664977855
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-663162464
@Spaceman1984 is this PR ready for review?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-670368691
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-669910562
Packaging result: ✔centos7 ✔debian. JID-1666
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-670419494
@Spaceman1984 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-668552119
Packaging result: ✔centos7 ✔debian. JID-1646
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-663474009
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-663474213
@Spaceman1984 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] alexandremattioli commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
alexandremattioli commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-671844548
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-658087004
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-664149853
@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-669037328
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-670272208
<b>Trillian test result (tid-2279)</b>
Environment: xenserver-70 (x2), Advanced Networking with Mgmt server 7
Total time taken: 52977 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4207-t2279-xenserver-70.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Smoke tests completed. 82 look OK, 2 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_add_delete_kubernetes_supported_version | `Error` | 1807.44 | test_kubernetes_supported_versions.py
test_04_extract_template | `Failure` | 1.17 | test_templates.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-668592524
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-670179371
<b>Trillian test result (tid-2277)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43959 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4207-t2277-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_outofbandmanagement.py
Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_routers.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 72 look OK, 12 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_deploy_kubernetes_cluster | `Error` | 0.07 | test_kubernetes_clusters.py
test_02_deploy_kubernetes_ha_cluster | `Error` | 0.03 | test_kubernetes_clusters.py
test_04_deploy_and_upgrade_kubernetes_cluster | `Error` | 0.03 | test_kubernetes_clusters.py
test_05_deploy_and_upgrade_kubernetes_ha_cluster | `Error` | 0.03 | test_kubernetes_clusters.py
test_06_deploy_and_invalid_upgrade_kubernetes_cluster | `Error` | 0.03 | test_kubernetes_clusters.py
test_07_deploy_and_scale_kubernetes_cluster | `Error` | 0.03 | test_kubernetes_clusters.py
ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py
ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py
ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py
ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py
ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
test_01_isolate_network_FW_PF_default_routes_egress_true | `Error` | 0.14 | test_routers_network_ops.py
test_02_isolate_network_FW_PF_default_routes_egress_false | `Error` | 0.15 | test_routers_network_ops.py
ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 1.29 | test_routers_network_ops.py
ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py
ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py
ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.10 | test_service_offerings.py
ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py
test_hostha_kvm_host_fencing | `Error` | 370.17 | test_hostha_kvm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-668538924
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-658099721
Packaging result: ✔centos7 ✔debian. JID-1576
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-665508759
@rhtyd, I checked the commas vs dots in the conversion, looks like it changes based on the locale and JDK version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-672704122
Tests LGTM, I'll merge this after few other PRs as this could potentially cause merge conflict with other PRs cc @DaanHoogland
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-668552814
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 edited a comment on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
Spaceman1984 edited a comment on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-665508759
@rhtyd, I checked the commas vs dots in the conversion, looks like it changes based on the locale.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-664602670
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-664216799
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-672392803
<b>Trillian test result (tid-2364)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44721 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4207-t2364-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 82 look OK, 2 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_add_delete_kubernetes_supported_version | `Error` | 1809.79 | test_kubernetes_supported_versions.py
test_hostha_kvm_host_degraded | `Error` | 5.78 | test_hostha_kvm.py
test_hostha_kvm_host_fencing | `Error` | 214.92 | test_hostha_kvm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 closed pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
Spaceman1984 closed pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-668553049
@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-670289459
<b>Trillian test result (tid-2284)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 47386 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4207-t2284-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 80 look OK, 4 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_deploy_kubernetes_cluster | `Error` | 0.06 | test_kubernetes_clusters.py
test_02_deploy_kubernetes_ha_cluster | `Error` | 0.04 | test_kubernetes_clusters.py
test_04_deploy_and_upgrade_kubernetes_cluster | `Error` | 0.03 | test_kubernetes_clusters.py
test_05_deploy_and_upgrade_kubernetes_ha_cluster | `Error` | 0.03 | test_kubernetes_clusters.py
test_06_deploy_and_invalid_upgrade_kubernetes_cluster | `Error` | 0.03 | test_kubernetes_clusters.py
test_07_deploy_and_scale_kubernetes_cluster | `Error` | 0.03 | test_kubernetes_clusters.py
test_01_reset_vm_on_reboot | `Error` | 7.20 | test_reset_vm_on_reboot.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 374.11 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | `Error` | 3857.87 | test_vpc_redundant.py
test_hostha_kvm_host_fencing | `Error` | 167.28 | test_hostha_kvm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on a change in pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#discussion_r462964867
##########
File path: test/integration/smoke/test_certauthority_root.py
##########
@@ -16,11 +16,10 @@
# under the License.
from nose.plugins.attrib import attr
-from marvin.cloudstackTestCase import *
-from marvin.cloudstackAPI import *
-from marvin.lib.utils import *
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.utils import cleanup_resources
from marvin.lib.base import *
-from marvin.lib.common import *
+from marvin.lib.common import list_hosts
from cryptography import x509
Review comment:
@borisstoyanov tests were failing when run outside of Travis.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-669896149
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-670416401
Packaging result: ✔centos7 ✔debian. JID-1673
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-668513565
Packaging result: ✔centos7 ✔debian. JID-1644
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-670402310
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on a change in pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on a change in pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#discussion_r462955752
##########
File path: test/integration/smoke/test_certauthority_root.py
##########
@@ -16,11 +16,10 @@
# under the License.
from nose.plugins.attrib import attr
-from marvin.cloudstackTestCase import *
-from marvin.cloudstackAPI import *
-from marvin.lib.utils import *
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.utils import cleanup_resources
from marvin.lib.base import *
-from marvin.lib.common import *
+from marvin.lib.common import list_hosts
from cryptography import x509
Review comment:
@Spaceman1984 why do we need changes in this file?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-671889024
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-666122830
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-663030331
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-670400667
Packaging result: ✔centos7 ✔debian. JID-1672
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-666123119
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on a change in pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#discussion_r464909158
##########
File path: utils/src/test/java/com/cloud/utils/HumanReadableJsonTest.java
##########
@@ -50,4 +51,14 @@ public void parseMatchJsonTest() {
assertEquals("[{\"size\":\"(0 bytes) 0\"}]", getHumanReadableBytesJson("[{\"size\": \"0\"}]"));
assertEquals("[{\"size\":\"(0 bytes) 0\",\"bytesSent\":\"(0 bytes) 0\"}]", getHumanReadableBytesJson("[{\"size\": \"0\", \"bytesSent\": \"0\"}]"));
}
+
+ @Test
+ public void localeTest() {
+ Locale.setDefault(Locale.UK); // UK test
Review comment:
@DaanHoogland I searched the code base, Cloudstack doesn't set a default locale, it will be picked up from the environment, which I believe is the correct behaviour.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-669896467
@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-668498818
@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#discussion_r463546704
##########
File path: utils/src/test/java/com/cloud/utils/HumanReadableJsonTest.java
##########
@@ -50,4 +51,14 @@ public void parseMatchJsonTest() {
assertEquals("[{\"size\":\"(0 bytes) 0\"}]", getHumanReadableBytesJson("[{\"size\": \"0\"}]"));
assertEquals("[{\"size\":\"(0 bytes) 0\",\"bytesSent\":\"(0 bytes) 0\"}]", getHumanReadableBytesJson("[{\"size\": \"0\", \"bytesSent\": \"0\"}]"));
}
+
+ @Test
+ public void localeTest() {
+ Locale.setDefault(Locale.UK); // UK test
Review comment:
I think "C" is the default locale. maybe this or some other more worldly locale is a good idea?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on a change in pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#discussion_r462165542
##########
File path: utils/src/test/java/com/cloud/utils/HumanReadableJsonTest.java
##########
@@ -0,0 +1,53 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+package com.cloud.utils;
+
+import org.junit.Test;
+
+import static org.junit.Assert.assertEquals;
+import static com.cloud.utils.HumanReadableJson.getHumanReadableBytesJson;
+
+public class HumanReadableJsonTest {
+
+ @Test
+ public void parseJsonObjectTest() {
+ assertEquals("{}", getHumanReadableBytesJson("{}"));
+ }
+ @Test
+ public void parseJsonArrayTest() {
+ assertEquals("[]", getHumanReadableBytesJson("[]"));
+ assertEquals("[{},{}]", getHumanReadableBytesJson("[{},{}]"));
+ }
+ @Test
+ public void parseSimpleJsonTest() {
+ assertEquals("[{\"object\":{}}]", getHumanReadableBytesJson("[{\"object\":{}}]"));
+ }
+ @Test
+ public void parseComplexJsonTest() {
+ assertEquals("[{\"object\":[]}]", getHumanReadableBytesJson("[{\"object\":[]}]"));
+ assertEquals("[{\"object\":[{},{}]}]", getHumanReadableBytesJson("[{\"object\":[{},{}]}]"));
+ assertEquals("[{\"object\":[]},{\"object\":[]}]", getHumanReadableBytesJson("[{\"object\":[]},{\"object\":[]}]"));
+ assertEquals("[{\"object\":[{\"object\":[]}]},{\"object\":[]}]", getHumanReadableBytesJson("[{\"object\":[{\"object\":[]}]},{\"object\":[]}]"));
+ }
+ @Test
+ public void parseMatchJsonTest() {
Review comment:
@rhtyd these tests already exist in NumbersUtilTest.java
##########
File path: utils/src/main/java/com/cloud/utils/NumbersUtil.java
##########
@@ -93,6 +95,13 @@ public static String toReadableSize(long bytes) {
return builder.toString();
}
+ public static String toHumanReadableSize(long size) {
Review comment:
I have added a check and a test for null which prevents an NPE.
##########
File path: utils/src/test/java/com/cloud/utils/HumanReadableJsonTest.java
##########
@@ -50,4 +51,14 @@ public void parseMatchJsonTest() {
assertEquals("[{\"size\":\"(0 bytes) 0\"}]", getHumanReadableBytesJson("[{\"size\": \"0\"}]"));
assertEquals("[{\"size\":\"(0 bytes) 0\",\"bytesSent\":\"(0 bytes) 0\"}]", getHumanReadableBytesJson("[{\"size\": \"0\", \"bytesSent\": \"0\"}]"));
}
+
+ @Test
+ public void localeTest() {
+ Locale.setDefault(Locale.UK); // UK test
Review comment:
@rhtyd From Java Docs:
"The Java Virtual Machine sets the default locale during startup based on the host environment. It is used by many locale-sensitive methods if no locale is explicitly specified. It can be changed using the setDefault method."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-670402633
@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-670368283
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-671881292
Packaging result: ✔centos7 ✔debian. JID-1709
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-669911433
@Spaceman1984 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-668401495
@Spaceman1984 can you fix the conflicts and address any outstanding comments. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-664149485
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-669771589
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-670419100
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-658061905
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-668539373
@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-671864029
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-670380735
Packaging result: ✔centos7 ✔debian. JID-1670
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-669037839
@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-658062412
@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#discussion_r462184183
##########
File path: utils/src/test/java/com/cloud/utils/HumanReadableJsonTest.java
##########
@@ -50,4 +51,14 @@ public void parseMatchJsonTest() {
assertEquals("[{\"size\":\"(0 bytes) 0\"}]", getHumanReadableBytesJson("[{\"size\": \"0\"}]"));
assertEquals("[{\"size\":\"(0 bytes) 0\",\"bytesSent\":\"(0 bytes) 0\"}]", getHumanReadableBytesJson("[{\"size\": \"0\", \"bytesSent\": \"0\"}]"));
}
+
+ @Test
+ public void localeTest() {
+ Locale.setDefault(Locale.UK); // UK test
Review comment:
@Spaceman1984 what's the default locale for CloudStack, is there a global setting or does it pick it up from OS?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-664162862
Packaging result: ✔centos7 ✔debian. JID-1602
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-658078530
Packaging result: ✖centos7 ✖debian. JID-1575
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-671888427
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-664216414
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-668568405
Packaging result: ✔centos7 ✔debian. JID-1647
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#discussion_r462080672
##########
File path: utils/src/test/java/com/cloud/utils/HumanReadableJsonTest.java
##########
@@ -0,0 +1,53 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+package com.cloud.utils;
+
+import org.junit.Test;
+
+import static org.junit.Assert.assertEquals;
+import static com.cloud.utils.HumanReadableJson.getHumanReadableBytesJson;
+
+public class HumanReadableJsonTest {
+
+ @Test
+ public void parseJsonObjectTest() {
+ assertEquals("{}", getHumanReadableBytesJson("{}"));
+ }
+ @Test
+ public void parseJsonArrayTest() {
+ assertEquals("[]", getHumanReadableBytesJson("[]"));
+ assertEquals("[{},{}]", getHumanReadableBytesJson("[{},{}]"));
+ }
+ @Test
+ public void parseSimpleJsonTest() {
+ assertEquals("[{\"object\":{}}]", getHumanReadableBytesJson("[{\"object\":{}}]"));
+ }
+ @Test
+ public void parseComplexJsonTest() {
+ assertEquals("[{\"object\":[]}]", getHumanReadableBytesJson("[{\"object\":[]}]"));
+ assertEquals("[{\"object\":[{},{}]}]", getHumanReadableBytesJson("[{\"object\":[{},{}]}]"));
+ assertEquals("[{\"object\":[]},{\"object\":[]}]", getHumanReadableBytesJson("[{\"object\":[]},{\"object\":[]}]"));
+ assertEquals("[{\"object\":[{\"object\":[]}]},{\"object\":[]}]", getHumanReadableBytesJson("[{\"object\":[{\"object\":[]}]},{\"object\":[]}]"));
+ }
+ @Test
+ public void parseMatchJsonTest() {
Review comment:
@Spaceman1984 can you add tests for non zero values, and see if the expected results match? (for kbs, mbs, gbs)
##########
File path: utils/src/main/java/com/cloud/utils/NumbersUtil.java
##########
@@ -93,6 +95,13 @@ public static String toReadableSize(long bytes) {
return builder.toString();
}
+ public static String toHumanReadableSize(long size) {
Review comment:
@Spaceman1984 can you add unit test for this method, giving some values such as zero and non-zero (to test KB, MB, GB, TB). Have you verified that all consumes would pass `long` to it and not `Long` which may potentially cause a NPE?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-663383055
> @Spaceman1984 is this PR ready for review?
@GabrielBrascher not yet, just a few more tweaks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd removed a comment on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
rhtyd removed a comment on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-672704122
Tests LGTM, I'll merge this after few other PRs as this could potentially cause merge conflict with other PRs cc @DaanHoogland
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-668592277
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-669911002
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-669052649
Packaging result: ✔centos7 ✔debian. JID-1653
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-670384315
@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org