You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "David Smiley (Jira)" <ji...@apache.org> on 2020/05/03 06:06:00 UTC
[jira] [Commented] (SOLR-14351) Harden MDCLoggingContext.clear
depth tracking
[ https://issues.apache.org/jira/browse/SOLR-14351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17098250#comment-17098250 ]
David Smiley commented on SOLR-14351:
-------------------------------------
Looks like I goofed in ZkContainer.java in which I removed the check zkController != null. Consequently, in _standalone mode_, you'll see NullPointerException errors (actually benign) with a stack looking like:
at org.apache.solr.core.ZkContainer.lambda$registerInZk$1(ZkContainer.java:195) at org.apache.solr.core.ZkContainer.lambda$registerInZk$1(ZkContainer.java:195) at org.apache.solr.core.ZkContainer.registerInZk(ZkContainer.java:224)
etc.
I'll push a fix tomorrow with some updated javadocs on this ZkContainer class.
> Harden MDCLoggingContext.clear depth tracking
> ---------------------------------------------
>
> Key: SOLR-14351
> URL: https://issues.apache.org/jira/browse/SOLR-14351
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Minor
> Fix For: 8.6
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> MDCLoggingContext tracks recursive calls and only clears when the recursion level is back down to 0. If a caller forgets to register and ends up calling clear any ways, then this can mess things up. Additionally I found at least one place this is occurring, which led me to investigate this matter.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org