You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2017/11/06 13:44:00 UTC
[jira] [Commented] (RATIS-135) Closed segments contribute to leaked
memory as eviction policies are not honoured
[ https://issues.apache.org/jira/browse/RATIS-135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16240306#comment-16240306 ]
Hadoop QA commented on RATIS-135:
---------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 3m 57s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 1s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 1m 23s{color} | {color:red} ratis-server in master failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 5s{color} | {color:red} ratis-server in master failed. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 32s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 21s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 6s{color} | {color:red} ratis-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 6s{color} | {color:red} ratis-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 6s{color} | {color:red} ratis-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 7s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 6s{color} | {color:red} ratis-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 14s{color} | {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 7m 13s{color} | {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/ratis:date2017-11-06 |
| JIRA Issue | RATIS-135 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12896158/RATIS-135.001.patch |
| Optional Tests | asflicense javac javadoc unit findbugs checkstyle compile |
| uname | Linux 8374e738548d 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh |
| git revision | master / 6d0d114 |
| Default Java | 1.8.0_131 |
| mvninstall | https://builds.apache.org/job/PreCommit-RATIS-Build/16/artifact/out/branch-mvninstall-ratis-server.txt |
| compile | https://builds.apache.org/job/PreCommit-RATIS-Build/16/artifact/out/branch-compile-ratis-server.txt |
| mvninstall | https://builds.apache.org/job/PreCommit-RATIS-Build/16/artifact/out/patch-mvninstall-ratis-server.txt |
| compile | https://builds.apache.org/job/PreCommit-RATIS-Build/16/artifact/out/patch-compile-ratis-server.txt |
| javac | https://builds.apache.org/job/PreCommit-RATIS-Build/16/artifact/out/patch-compile-ratis-server.txt |
| unit | https://builds.apache.org/job/PreCommit-RATIS-Build/16/artifact/out/patch-unit-ratis-server.txt |
| Test Results | https://builds.apache.org/job/PreCommit-RATIS-Build/16/testReport/ |
| modules | C: ratis-server U: ratis-server |
| Console output | https://builds.apache.org/job/PreCommit-RATIS-Build/16/console |
| Powered by | Apache Yetus 0.5.0 http://yetus.apache.org |
This message was automatically generated.
> Closed segments contribute to leaked memory as eviction policies are not honoured
> ---------------------------------------------------------------------------------
>
> Key: RATIS-135
> URL: https://issues.apache.org/jira/browse/RATIS-135
> Project: Ratis
> Issue Type: Bug
> Reporter: Mukul Kumar Singh
> Assignee: Mukul Kumar Singh
> Attachments: RATIS-135.001.patch
>
>
> Closed segments leak memory as eviction does not remove these segments from closed segments list.
> {code}
> void evictCache(long[] followerIndices, long flushedIndex,
> long lastAppliedIndex) {
> List<LogSegment> toEvict = evictionPolicy.evict(followerIndices,
> flushedIndex, lastAppliedIndex, closedSegments, maxCachedSegments);
> for (LogSegment s : toEvict) {
> s.evictCache();
> }
> {code}
> After the segments have been marked for eviction, they should be removed from queue as well.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)