You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/11 01:33:55 UTC

[GitHub] [superset] ktmud commented on a change in pull request #12341: fix: annotation layer modal err handling

ktmud commented on a change in pull request #12341:
URL: https://github.com/apache/superset/pull/12341#discussion_r554655129



##########
File path: superset-frontend/src/views/CRUD/annotation/AnnotationModal.tsx
##########
@@ -114,6 +114,16 @@ const AnnotationModal: FunctionComponent<AnnotationModalProps> = ({
   // Functions
   const hide = () => {
     setIsHidden(true);
+
+    // Reset annotation
+    setCurrentAnnotation({
+      short_descr: '',

Review comment:
       Or create a short helper function `resetAnnotation()`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org