You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Sheng Yang <sh...@yasker.org> on 2013/06/19 19:59:45 UTC

Review Request: Re-enabling baremetal for 4.2/master

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11977/
-----------------------------------------------------------

Review request for cloudstack.


Description
-------

This patch would re-enable baremetal support for master, which we've disabled on 4.1 release due to release blocker bugs.

After review passed, I would apply the patch to master in small patches.


This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-3077.


Diffs
-----

  client/pom.xml ab758eb 
  client/tomcatconf/applicationContext.xml.in 049e483 
  client/tomcatconf/componentContext.xml.in 93ef21f 
  client/tomcatconf/nonossComponentContext.xml.in 143aa22 
  plugins/hypervisors/baremetal/src/com/cloud/baremetal/manager/BareMetalDiscoverer.java edb5dea 
  plugins/hypervisors/baremetal/src/com/cloud/baremetal/manager/BareMetalTemplateAdapter.java 928183b 
  plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetalDhcpElement.java fdf8b63 
  plugins/network-elements/dns-notifier/resources/components-example.xml 2e9c5be 
  server/src/com/cloud/configuration/Config.java f6fa974 
  server/src/com/cloud/network/NetworkServiceImpl.java aace68d 
  setup/db/db/schema-410to420.sql bcdf2d9 

Diff: https://reviews.apache.org/r/11977/diff/


Testing
-------

All the following bugs(which are the original blocker for 4.1 releases) are tested against the patch.

https://issues.apache.org/jira/browse/CLOUDSTACK-1610
https://issues.apache.org/jira/browse/CLOUDSTACK-1618
https://issues.apache.org/jira/browse/CLOUDSTACK-1614
https://issues.apache.org/jira/browse/CLOUDSTACK-1440


Thanks,

Sheng Yang


Re: Review Request 11977: Re-enabling baremetal for 4.2/master

Posted by Chiradeep Vittal <Ch...@citrix.com>.
This actually breaks basic zone and re-opens bug CLOUDSTACK-1812


On 6/30/13 12:05 PM, "Prasanna Santhanam" <ts...@apache.org> wrote:

>
>-----------------------------------------------------------
>This is an automatically generated e-mail. To reply, visit:
>https://reviews.apache.org/r/11977/#review22577
>-----------------------------------------------------------
>
>
>This was submitted. Closing the review
>http://cloudstack.markmail.org/thread/xfx4sjwyurnyn2xo
>
>- Prasanna Santhanam
>
>
>On June 19, 2013, 5:59 p.m., Sheng Yang wrote:
>> 
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/11977/
>> -----------------------------------------------------------
>> 
>> (Updated June 19, 2013, 5:59 p.m.)
>> 
>> 
>> Review request for cloudstack.
>> 
>> 
>> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3077
>> 
>> 
>> Repository: cloudstack-git
>> 
>> 
>> Description
>> -------
>> 
>> This patch would re-enable baremetal support for master, which we've
>>disabled on 4.1 release due to release blocker bugs.
>> 
>> After review passed, I would apply the patch to master in small patches.
>> 
>> 
>> Diffs
>> -----
>> 
>>   client/pom.xml ab758eb
>>   client/tomcatconf/applicationContext.xml.in 049e483
>>   client/tomcatconf/componentContext.xml.in 93ef21f
>>   client/tomcatconf/nonossComponentContext.xml.in 143aa22
>>   
>>plugins/hypervisors/baremetal/src/com/cloud/baremetal/manager/BareMetalDi
>>scoverer.java edb5dea
>>   
>>plugins/hypervisors/baremetal/src/com/cloud/baremetal/manager/BareMetalTe
>>mplateAdapter.java 928183b
>>   
>>plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/Bare
>>metalDhcpElement.java fdf8b63
>>   
>>plugins/network-elements/dns-notifier/resources/components-example.xml
>>2e9c5be 
>>   server/src/com/cloud/configuration/Config.java f6fa974
>>   server/src/com/cloud/network/NetworkServiceImpl.java aace68d
>>   setup/db/db/schema-410to420.sql bcdf2d9
>> 
>> Diff: https://reviews.apache.org/r/11977/diff/
>> 
>> 
>> Testing
>> -------
>> 
>> All the following bugs(which are the original blocker for 4.1 releases)
>>are tested against the patch.
>> 
>> https://issues.apache.org/jira/browse/CLOUDSTACK-1610
>> https://issues.apache.org/jira/browse/CLOUDSTACK-1618
>> https://issues.apache.org/jira/browse/CLOUDSTACK-1614
>> https://issues.apache.org/jira/browse/CLOUDSTACK-1440
>> 
>> 
>> Thanks,
>> 
>> Sheng Yang
>> 
>>
>


Re: Review Request 11977: Re-enabling baremetal for 4.2/master

Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11977/#review22577
-----------------------------------------------------------


This was submitted. Closing the review
http://cloudstack.markmail.org/thread/xfx4sjwyurnyn2xo

- Prasanna Santhanam


On June 19, 2013, 5:59 p.m., Sheng Yang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11977/
> -----------------------------------------------------------
> 
> (Updated June 19, 2013, 5:59 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3077
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> This patch would re-enable baremetal support for master, which we've disabled on 4.1 release due to release blocker bugs.
> 
> After review passed, I would apply the patch to master in small patches.
> 
> 
> Diffs
> -----
> 
>   client/pom.xml ab758eb 
>   client/tomcatconf/applicationContext.xml.in 049e483 
>   client/tomcatconf/componentContext.xml.in 93ef21f 
>   client/tomcatconf/nonossComponentContext.xml.in 143aa22 
>   plugins/hypervisors/baremetal/src/com/cloud/baremetal/manager/BareMetalDiscoverer.java edb5dea 
>   plugins/hypervisors/baremetal/src/com/cloud/baremetal/manager/BareMetalTemplateAdapter.java 928183b 
>   plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetalDhcpElement.java fdf8b63 
>   plugins/network-elements/dns-notifier/resources/components-example.xml 2e9c5be 
>   server/src/com/cloud/configuration/Config.java f6fa974 
>   server/src/com/cloud/network/NetworkServiceImpl.java aace68d 
>   setup/db/db/schema-410to420.sql bcdf2d9 
> 
> Diff: https://reviews.apache.org/r/11977/diff/
> 
> 
> Testing
> -------
> 
> All the following bugs(which are the original blocker for 4.1 releases) are tested against the patch.
> 
> https://issues.apache.org/jira/browse/CLOUDSTACK-1610
> https://issues.apache.org/jira/browse/CLOUDSTACK-1618
> https://issues.apache.org/jira/browse/CLOUDSTACK-1614
> https://issues.apache.org/jira/browse/CLOUDSTACK-1440
> 
> 
> Thanks,
> 
> Sheng Yang
> 
>