[PR] Support parsing more syntax of Doris CREATE TABLE [shardingsphere]

["terrymanu (via GitHub)" <gi...@apache.org>]

terrymanu opened a new pull request, #39568:
URL: https://github.com/apache/shardingsphere/pull/39568

   - allow empty partition definition list for dynamic partition tables
   - support rollup clause with optional duplicate key in CREATE TABLE
   - support multi-column hash distribution, RANDOM distribution and AUTO buckets
   - support multi-column RANGE/LIST partition with tuple partition values
   - support HLL column type and INVERTED index type in CREATE TABLE
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Support parsing more syntax of Doris CREATE TABLE [shardingsphere]

["terrymanu (via GitHub)" <gi...@apache.org>]

terrymanu merged PR #39568:
URL: https://github.com/apache/shardingsphere/pull/39568


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Support parsing more syntax of Doris CREATE TABLE [shardingsphere]

["terrymanu (via GitHub)" <gi...@apache.org>]

terrymanu commented on PR #39568:
URL: https://github.com/apache/shardingsphere/pull/39568#issuecomment-5381111825

   ### Result
   
   **Review Result: Mergeable**
   
   The single blocking issue from the previous round (`HLL` missing from the identifier whitelist) is fixed and verified in the new commit `cba7f892`: the delta is exactly 3 files / +9 lines (`| HLL` added in `BaseRule.g4`, plus a protecting test-case pair for `hll` used as an identifier). `hll` as a table name, column name, and SELECT identifier all parse again, matching pre-PR behavior, and the new case prevents regression. The remaining syntax enhancements match the official Doris CREATE-TABLE documentation item by item, and no other candidate passed the Finding Proof Gate.
   
   ### Evidence
   
   - PR #39568 latest head `cba7f892` (2 commits, 6 files, +147/-10), base `master@ed24f824`; local HEAD matches it, and the `88af2a86..cba7f892` delta was verified to be exactly the fix above.
   - Identifier regression tests: `CREATE TABLE hll (...)`, a column named `hll`, and `SELECT hll FROM ...` all parse; the `bitmap` control is unaffected; the type syntax `v1 HLL HLL_UNION` is unaffected by the whitelist (all 24 official doc examples plus all 5 SQL cases from issue #31494 re-verified passing).
   - `InternalDorisParserIT`: 1338 tests, 0 failures, 0 errors (including the new `create_table_with_hll_as_identifier_doris`); `spotless:apply` and `checkstyle:check` pass.
   - The bare-line whitelist style matches upstream precedent #38400 (`HLL_UNION`); zero changes to MySQL trunk or MariaDB files; DORIS CHANGED/ADDED markers follow the branch-dialect convention.
   
   ### Coverage
   
   - Reviewed head: `cba7f892`; authoritative scope: the GitHub changed-file list (6 files), matched one-to-one against the local triple-dot list.
   - Behavior clusters: empty partition list, CREATE TABLE rollup with optional DUPLICATE KEY, distribution clause (multi-column HASH / RANDOM / optional or AUTO buckets), multi-column RANGE/LIST partitioning, HLL type, INVERTED index plus the `createIndex` reorder, visitor null-safety, and the 12+1 test cases — all completed through the root-cause, blast-radius, and tests lenses plus a convergence pass.
   - Official syntax evidence: Doris CREATE-TABLE documentation (dev, the page linked by issue #31494), including the clause order `distribution_desc → [rollup_list] → [properties]` and the non-reserved status of `HLL`.
   - Unresolved gaps: none. This conclusion is a Code Correctness Review of the code scope only; CI was not queried or assessed — required CI must still pass through the normal workflow before merge.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org