You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2026/03/18 23:57:03 UTC
[PR] [SPARK-56068] Use `Date.FormatStyle` instead of `DateFormatter` [spark-connect-swift]
dongjoon-hyun opened a new pull request, #316:
URL: https://github.com/apache/spark-connect-swift/pull/316
### What changes were proposed in this pull request?
This PR replaces the legacy `DateFormatter` with the modern `Date.FormatStyle` API in `TimestampArray`.
### Why are the changes needed?
`DateFormatter` is an Objective-C-based legacy API. `Date.FormatStyle` is the modern **Swift-native alternative**, providing a more type-safe and idiomatic approach to date formatting.
### Does this PR introduce _any_ user-facing change?
Yes. `FormattingOptions.dateFormat: String` is replaced with `FormattingOptions.formatStyle: Date.FormatStyle`. The default formatting behavior remains equivalent.
### How was this patch tested?
Pass the CI with the existing tests.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 4.6)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-56068] Use `Date.FormatStyle` instead of `DateFormatter` [spark-connect-swift]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #316:
URL: https://github.com/apache/spark-connect-swift/pull/316#issuecomment-4086567424
Merged to main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-56068] Use `Date.FormatStyle` instead of `DateFormatter` [spark-connect-swift]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #316:
URL: https://github.com/apache/spark-connect-swift/pull/316#issuecomment-4086564006
Thank you, @viirya . 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-56068] Use `Date.FormatStyle` instead of `DateFormatter` [spark-connect-swift]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #316: [SPARK-56068] Use `Date.FormatStyle` instead of `DateFormatter`
URL: https://github.com/apache/spark-connect-swift/pull/316
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org