You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2015/09/20 03:38:22 UTC
Review Request 38529: CMake: Only compile proc_tests.cpp for Linux
platforms.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38529/
-----------------------------------------------------------
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Repository: mesos
Description
-------
CMake: Only compile proc_tests.cpp for Linux platforms.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt baa648aacfd5204c33e102b58126862729fbb612
Diff: https://reviews.apache.org/r/38529/diff/
Testing
-------
Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms:
* OS X 10.10
* Windows 10
* Ubuntu 14.04.2
Thanks,
Alex Clemmer
Re: Review Request 38529: CMake: Only compile proc_tests.cpp for Linux
platforms.
Posted by Artem Harutyunyan <ar...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38529/#review100591
-----------------------------------------------------------
LGTM.
- Artem Harutyunyan
On Sept. 19, 2015, 7:07 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38529/
> -----------------------------------------------------------
>
> (Updated Sept. 19, 2015, 7:07 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3345
> https://issues.apache.org/jira/browse/MESOS-3345
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake: Only compile proc_tests.cpp for Linux platforms.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt baa648aacfd5204c33e102b58126862729fbb612
>
> Diff: https://reviews.apache.org/r/38529/diff/
>
>
> Testing
> -------
>
> Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms:
>
> * OS X 10.10
> * Windows 10
> * Ubuntu 14.04.2
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 38529: CMake: Only compile proc_tests.cpp for Linux
platforms.
Posted by Alex Clemmer <cl...@gmail.com>.
> On Sept. 21, 2015, 5:55 p.m., Joseph Wu wrote:
> > Ship It!
> >
> > This is required because `stout/proc.hpp` is Linux-only, right?
Correct!
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38529/#review99778
-----------------------------------------------------------
On Sept. 20, 2015, 2:07 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38529/
> -----------------------------------------------------------
>
> (Updated Sept. 20, 2015, 2:07 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3345
> https://issues.apache.org/jira/browse/MESOS-3345
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake: Only compile proc_tests.cpp for Linux platforms.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt baa648aacfd5204c33e102b58126862729fbb612
>
> Diff: https://reviews.apache.org/r/38529/diff/
>
>
> Testing
> -------
>
> Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms:
>
> * OS X 10.10
> * Windows 10
> * Ubuntu 14.04.2
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 38529: CMake: Only compile proc_tests.cpp for Linux
platforms.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38529/#review99778
-----------------------------------------------------------
Ship it!
Ship It!
This is required because `stout/proc.hpp` is Linux-only, right?
- Joseph Wu
On Sept. 19, 2015, 7:07 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38529/
> -----------------------------------------------------------
>
> (Updated Sept. 19, 2015, 7:07 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3345
> https://issues.apache.org/jira/browse/MESOS-3345
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake: Only compile proc_tests.cpp for Linux platforms.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt baa648aacfd5204c33e102b58126862729fbb612
>
> Diff: https://reviews.apache.org/r/38529/diff/
>
>
> Testing
> -------
>
> Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms:
>
> * OS X 10.10
> * Windows 10
> * Ubuntu 14.04.2
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 38529: CMake: Only compile proc_tests.cpp for Linux
platforms.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38529/#review100722
-----------------------------------------------------------
Ship it!
- Joris Van Remoortere
On Sept. 20, 2015, 2:07 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38529/
> -----------------------------------------------------------
>
> (Updated Sept. 20, 2015, 2:07 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3345
> https://issues.apache.org/jira/browse/MESOS-3345
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake: Only compile proc_tests.cpp for Linux platforms.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt baa648aacfd5204c33e102b58126862729fbb612
>
> Diff: https://reviews.apache.org/r/38529/diff/
>
>
> Testing
> -------
>
> Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms:
>
> * OS X 10.10
> * Windows 10
> * Ubuntu 14.04.2
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 38529: CMake: Only compile proc_tests.cpp for Linux
platforms.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38529/
-----------------------------------------------------------
(Updated Sept. 20, 2015, 2:07 a.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Bugs: MESOS-3345
https://issues.apache.org/jira/browse/MESOS-3345
Repository: mesos
Description
-------
CMake: Only compile proc_tests.cpp for Linux platforms.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt baa648aacfd5204c33e102b58126862729fbb612
Diff: https://reviews.apache.org/r/38529/diff/
Testing
-------
Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms:
* OS X 10.10
* Windows 10
* Ubuntu 14.04.2
Thanks,
Alex Clemmer