You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "englefly (via GitHub)" <gi...@apache.org> on 2026/01/22 09:44:19 UTC
[PR] [fix](nereids) when Expression has more than 2 children, the attribute hasUnbound is not set correctly [doris]
englefly opened a new pull request, #60152:
URL: https://github.com/apache/doris/pull/60152
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](nereids) when Expression has no more than 2 children, the attribute hasUnbound is not set correctly [doris]
Posted by "englefly (via GitHub)" <gi...@apache.org>.
englefly commented on PR #60152:
URL: https://github.com/apache/doris/pull/60152#issuecomment-3787871273
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](nereids) when Expression has no more than 2 children, the attribute hasUnbound is not set correctly [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60152:
URL: https://github.com/apache/doris/pull/60152#issuecomment-3808820654
# FE Regression Coverage Report
Increment line coverage ` 100.00% (3/3)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60152_91223a9a349fbc30026dd721246f29d4f8ef23e7_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60152_91223a9a349fbc30026dd721246f29d4f8ef23e7_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](nereids) when Expression has no more than 2 children, the attribute hasUnbound is not set correctly [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #60152:
URL: https://github.com/apache/doris/pull/60152#issuecomment-3809190636
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](nereids) when Expression has more than 2 children, the attribute hasUnbound is not set correctly [doris]
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on PR #60152:
URL: https://github.com/apache/doris/pull/60152#issuecomment-3783509297
add related PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](nereids) when Expression has more than 2 children, the attribute hasUnbound is not set correctly [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60152:
URL: https://github.com/apache/doris/pull/60152#issuecomment-3783467751
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](nereids) when Expression has no more than 2 children, the attribute hasUnbound is not set correctly [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60152:
URL: https://github.com/apache/doris/pull/60152#issuecomment-3804346477
# FE UT Coverage Report
Increment line coverage ` 100.00% (3/3)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60152_91223a9a349fbc30026dd721246f29d4f8ef23e7/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60152_91223a9a349fbc30026dd721246f29d4f8ef23e7/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](nereids) when Expression has more than 2 children, the attribute hasUnbound is not set correctly [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #60152:
URL: https://github.com/apache/doris/pull/60152#issuecomment-3783496158
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](nereids) when Expression has more than 2 children, the attribute hasUnbound is not set correctly [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #60152:
URL: https://github.com/apache/doris/pull/60152#issuecomment-3783496303
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](nereids) when Expression has no more than 2 children, the attribute hasUnbound is not set correctly [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60152:
URL: https://github.com/apache/doris/pull/60152#issuecomment-3804517177
<details>
<summary>TPC-H: <b>Total hot run time: 33069 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 91223a9a349fbc30026dd721246f29d4f8ef23e7, data reload: false
------ Round 1 ----------------------------------
q1 17599 5241 5050 5050
q2 2031 304 192 192
q3 10215 1302 803 803
q4 10209 851 322 322
q5 7858 2182 1953 1953
q6 246 185 153 153
q7 902 741 632 632
q8 9289 1383 1124 1124
q9 5281 4874 4868 4868
q10 6863 1951 1577 1577
q11 514 292 277 277
q12 392 383 221 221
q13 17805 4088 3245 3245
q14 248 245 220 220
q15 910 839 816 816
q16 679 685 620 620
q17 645 741 547 547
q18 7022 6461 7553 6461
q19 2587 1029 694 694
q20 412 351 243 243
q21 2873 2270 1993 1993
q22 1138 1128 1058 1058
Total cold run time: 105718 ms
Total hot run time: 33069 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5683 5478 5426 5426
q2 263 337 280 280
q3 2416 2810 2540 2540
q4 1468 2009 1566 1566
q5 4705 4414 4517 4414
q6 228 177 139 139
q7 2065 1935 1789 1789
q8 2579 2478 2540 2478
q9 7782 7512 7299 7299
q10 2874 2987 2436 2436
q11 542 456 437 437
q12 622 692 569 569
q13 3535 4011 3227 3227
q14 272 281 273 273
q15 839 806 787 787
q16 649 686 630 630
q17 1079 1323 1294 1294
q18 7553 7564 7323 7323
q19 822 772 775 772
q20 1974 2059 1889 1889
q21 4462 4121 4152 4121
q22 1082 1047 983 983
Total cold run time: 53494 ms
Total hot run time: 50672 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](nereids) when Expression has no more than 2 children, the attribute hasUnbound is not set correctly [doris]
Posted by "englefly (via GitHub)" <gi...@apache.org>.
englefly merged PR #60152:
URL: https://github.com/apache/doris/pull/60152
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](nereids) when Expression has no more than 2 children, the attribute hasUnbound is not set correctly [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60152:
URL: https://github.com/apache/doris/pull/60152#issuecomment-3804588231
<details>
<summary>ClickBench: <b>Total hot run time: 28.07 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 91223a9a349fbc30026dd721246f29d4f8ef23e7, data reload: false
query1 0.06 0.05 0.05
query2 0.09 0.05 0.05
query3 0.26 0.09 0.08
query4 1.61 0.11 0.11
query5 0.27 0.27 0.25
query6 1.17 0.68 0.66
query7 0.03 0.02 0.02
query8 0.05 0.04 0.04
query9 0.57 0.50 0.49
query10 0.56 0.54 0.55
query11 0.15 0.10 0.10
query12 0.14 0.10 0.12
query13 0.63 0.62 0.62
query14 1.07 1.05 1.04
query15 0.88 0.86 0.87
query16 0.41 0.39 0.43
query17 1.13 1.14 1.16
query18 0.23 0.22 0.21
query19 2.07 2.01 1.93
query20 0.01 0.01 0.02
query21 15.42 0.26 0.13
query22 5.30 0.05 0.05
query23 16.11 0.28 0.10
query24 1.48 0.31 0.17
query25 0.06 0.09 0.07
query26 0.14 0.13 0.13
query27 0.09 0.09 0.06
query28 3.22 1.16 0.96
query29 12.54 3.86 3.14
query30 0.28 0.13 0.11
query31 2.82 0.66 0.40
query32 3.24 0.60 0.49
query33 3.20 3.28 3.32
query34 16.50 5.38 4.71
query35 4.82 4.84 4.72
query36 0.65 0.49 0.49
query37 0.11 0.08 0.07
query38 0.07 0.05 0.03
query39 0.04 0.03 0.03
query40 0.18 0.17 0.15
query41 0.08 0.03 0.03
query42 0.04 0.03 0.03
query43 0.05 0.04 0.03
Total cold run time: 97.83 s
Total hot run time: 28.07 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](nereids) when Expression has more than 2 children, the attribute hasUnbound is not set correctly [doris]
Posted by "englefly (via GitHub)" <gi...@apache.org>.
englefly commented on PR #60152:
URL: https://github.com/apache/doris/pull/60152#issuecomment-3783468151
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](nereids) when Expression has no more than 2 children, the attribute hasUnbound is not set correctly [doris]
Posted by "englefly (via GitHub)" <gi...@apache.org>.
englefly commented on PR #60152:
URL: https://github.com/apache/doris/pull/60152#issuecomment-3804027151
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](nereids) when Expression has no more than 2 children, the attribute hasUnbound is not set correctly [doris]
Posted by "englefly (via GitHub)" <gi...@apache.org>.
englefly commented on PR #60152:
URL: https://github.com/apache/doris/pull/60152#issuecomment-3808505935
run cloud_p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org