You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by zh...@apache.org on 2008/05/29 05:23:01 UTC

svn commit: r661197 - /incubator/shindig/trunk/features/flash/flash.js

Author: zhen
Date: Wed May 28 20:23:01 2008
New Revision: 661197

URL: http://svn.apache.org/viewvc?rev=661197&view=rev
Log:
Fixed a function-always-returning-undefined bug in gadgets.flash.embedCachedFlash, _IG_EmbedFlash, and _IG_EmbedCachedFlash.
According to the spec, they should return a boolean value.


Modified:
    incubator/shindig/trunk/features/flash/flash.js

Modified: incubator/shindig/trunk/features/flash/flash.js
URL: http://svn.apache.org/viewvc/incubator/shindig/trunk/features/flash/flash.js?rev=661197&r1=661196&r2=661197&view=diff
==============================================================================
--- incubator/shindig/trunk/features/flash/flash.js (original)
+++ incubator/shindig/trunk/features/flash/flash.js Wed May 28 20:23:01 2008
@@ -177,18 +177,18 @@
 gadgets.flash.embedCachedFlash = function() {
   var args = Array.prototype.slice.call(arguments);
   args[0] = gadgets.io.getProxyUrl(args[0]);
-  gadgets.flash.embedFlash.apply(this, args);
+  return gadgets.flash.embedFlash.apply(this, args);
 };
 
 // Aliases for legacy code
 var _IG_GetFlashMajorVersion = gadgets.flash.getMajorVersion;
 var _IG_EmbedFlash = function(swfUrl, swfContainer, opt_params) {
-  gadgets.flash.embedFlash(swfUrl, swfContainer, opt_params.swf_version,
+  return gadgets.flash.embedFlash(swfUrl, swfContainer, opt_params.swf_version,
       opt_params);
 };
 
 var _IG_EmbedCachedFlash = function(swfUrl, swfContainer, opt_params) {
-  gadgets.flash.embedCachedFlash(swfUrl, swfContainer, opt_params.swf_version,
+  return gadgets.flash.embedCachedFlash(swfUrl, swfContainer, opt_params.swf_version,
       opt_params);
 };