You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "ediconss (via GitHub)" <gi...@apache.org> on 2023/06/19 08:55:09 UTC

[GitHub] [shardingsphere] ediconss opened a new issue, #26434: SQL Parser CommentStatement get comment

ediconss opened a new issue, #26434:
URL: https://github.com/apache/shardingsphere/issues/26434

   ## Feature Request
   
   When using SQL Parser to parse PG comment statements such as 
   "COMMENT ON COLUMN public. test. c1 is 'test ';" or
   "COMMENT ON TABLE public. test is 'test';"
   
   only can get table and field name ,
   cant  not get comment.
   
   Can add comment fild in org.apache.shardingsphere.sql.parser.sql.common.statement.ddl.CommentStatement ?
   
   
   package org.apache.shardingsphere.sql.parser.sql.common.statement.ddl;
   
   /**
    * Comment statement.
    */
   @Getter
   @Setter
   public abstract class CommentStatement extends AbstractSQLStatement implements DDLStatement {
       
       private SimpleTableSegment table;
       
       private ColumnSegment column;
   }
   
   
   ### Is your feature request related to a problem?
   
   
   ### Describe the feature you would like.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] ediconss commented on issue #26434: SQL Parser CommentStatement get comment

Posted by "ediconss (via GitHub)" <gi...@apache.org>.
ediconss commented on issue #26434:
URL: https://github.com/apache/shardingsphere/issues/26434#issuecomment-1599924274

   > Comment is a seperated sql. Already has `PostgreSQLCommentStatement` for this
   
    I sea CommentStatement has  OpenGaussCommentStatement，OracleCommentStatement，PostgreSQLCommentStatement subclass , These three databases all have  'COMMENT ON' SQL,  so can add comment fild in CommentStatement ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] ediconss commented on issue #26434: SQL Parser CommentStatement get comment

Posted by "ediconss (via GitHub)" <gi...@apache.org>.
ediconss commented on issue #26434:
URL: https://github.com/apache/shardingsphere/issues/26434#issuecomment-1599923853

   > Comment is a seperated sql. Already has `PostgreSQLCommentStatement` for this
   
   But In PostgreSQLCommentStatement has not get comment method
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] github-actions[bot] commented on issue #26434: SQL Parser CommentStatement get comment

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #26434:
URL: https://github.com/apache/shardingsphere/issues/26434#issuecomment-1646184051

   There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tuichenchuxin commented on issue #26434: SQL Parser CommentStatement get comment

Posted by "tuichenchuxin (via GitHub)" <gi...@apache.org>.
tuichenchuxin commented on issue #26434:
URL: https://github.com/apache/shardingsphere/issues/26434#issuecomment-1598372767

   Comment is a seperated sql. 
   Already has `PostgreSQLCommentStatement` for this


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org