You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by wurstmeister <gi...@git.apache.org> on 2014/10/05 22:56:46 UTC
[GitHub] storm pull request: STORM-307: reset LocalState if files are corru...
GitHub user wurstmeister opened a pull request:
https://github.com/apache/storm/pull/282
STORM-307: reset LocalState if files are corrupt
* allow supervisor to start even if LocalState files are empty
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wurstmeister/incubator-storm STORM-307
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/282.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #282
----
commit b2ecd44a7ee13d6c98171c63d056bdef481d6e0f
Author: Wurstmeister <wu...@users.noreply.github.com>
Date: 2014-10-05T20:46:24Z
STORM-307: reset LocalState if files are corrupt
* allow supervisor to start if LocalState was corrupted
Change-Id: I3dbf957dd2e37c9c6be39dab29a9a71e99b7a2c3
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-307: reset LocalState if files are corru...
Posted by wurstmeister <gi...@git.apache.org>.
Github user wurstmeister commented on the pull request:
https://github.com/apache/storm/pull/282#issuecomment-57995451
Thanks @HeartSaVioR! should be fixed now.
I was wondering if we actually need this retry logic. i.e. if we can just reset the state whenever there is an IOException (rather than not starting up and users having to manually remove state files).
I am not sure why the retry logic was implemented this way, so I picked out the empty file case because that's been reported multiple times (incl the workaround of resetting the state).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-307: reset LocalState if files are corru...
Posted by clockfly <gi...@git.apache.org>.
Github user clockfly commented on the pull request:
https://github.com/apache/storm/pull/282#issuecomment-61636291
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-307: reset LocalState if files are corru...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/282#issuecomment-60423299
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-307: reset LocalState if files are corru...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/282
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-307: reset LocalState if files are corru...
Posted by Parth-Brahmbhatt <gi...@git.apache.org>.
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/282#issuecomment-60429586
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---