You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@skywalking.apache.org by "rabajaj0509 (via GitHub)" <gi...@apache.org> on 2023/06/09 18:00:37 UTC
[GitHub] [skywalking-terraform] rabajaj0509 opened a new pull request, #5: Add option to control key pair retention
rabajaj0509 opened a new pull request, #5:
URL: https://github.com/apache/skywalking-terraform/pull/5
Introduce the `keep_key_pair` variable to allow users to control whether to keep or delete the key pair. When set to true, the key pair is created and retained for future use. When set to false, the key pair is not created, providing flexibility for new installations or specific use cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-terraform] kezhenxu94 commented on pull request #5: Add option to control key pair retention
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on PR #5:
URL: https://github.com/apache/skywalking-terraform/pull/5#issuecomment-1586478834
https://github.com/apache/skywalking-terraform/pull/3#pullrequestreview-1471045760
> we can also add a variable to switch whether creating the key pair or not, this can be especially useful for new installation
Hi sorry, looks like I didn't make myself clear in that comment, what I meant is to add a task that creates the key pair for the users, so that users don't have to create the key pair by themself before they can use our Terraform module, specifically, what I'm proposing is to add something like this:
```
resource "tls_private_key" "skywalking" {
algorithm = "RSA"
rsa_bits = 4096
}
```
and use that public key to create the AWS machines and use the private key to connect to the machine in Ansible playbook.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-terraform] kezhenxu94 closed pull request #5: Add option to control key pair retention
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 closed pull request #5: Add option to control key pair retention
URL: https://github.com/apache/skywalking-terraform/pull/5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-terraform] kezhenxu94 commented on pull request #5: Add option to control key pair retention
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on PR #5:
URL: https://github.com/apache/skywalking-terraform/pull/5#issuecomment-1666854702
This is done in my recent improvements PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org