You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/07/23 05:27:22 UTC
[GitHub] [shardingsphere] strongduanmu opened a new issue, #16290: Add more unit test for ShardingRuleAlgorithmProviderConfigurationYamlSwapper
strongduanmu opened a new issue, #16290:
URL: https://github.com/apache/shardingsphere/issues/16290
Hi community,
We need to add more unit test for ShardingRuleAlgorithmProviderConfigurationYamlSwapper.
- [x] ShardingRuleAlgorithmProviderConfigurationYamlSwapper#swapToYamlConfiguration
- [x] ShardingRuleAlgorithmProviderConfigurationYamlSwapper#swapToObject
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu closed issue #16290: Add more unit test for ShardingRuleAlgorithmProviderConfigurationYamlSwapper
Posted by GitBox <gi...@apache.org>.
terrymanu closed issue #16290: Add more unit test for ShardingRuleAlgorithmProviderConfigurationYamlSwapper
URL: https://github.com/apache/shardingsphere/issues/16290
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] lushaorong commented on issue #16290: Add more unit test for ShardingRuleAlgorithmProviderConfigurationYamlSwapper
Posted by GitBox <gi...@apache.org>.
lushaorong commented on issue #16290:
URL: https://github.com/apache/shardingsphere/issues/16290#issuecomment-1188598093
I want to try this work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on issue #16290: Add more unit test for ShardingRuleAlgorithmProviderConfigurationYamlSwapper
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #16290:
URL: https://github.com/apache/shardingsphere/issues/16290#issuecomment-1086974232
@itsAfnanAlam Welcome, I will assign this issue to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on issue #16290: Add more unit test for ShardingRuleAlgorithmProviderConfigurationYamlSwapper
Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #16290:
URL: https://github.com/apache/shardingsphere/issues/16290#issuecomment-1193063947
The test coverage does not reach 100% for `setYamlStrategies` `swapToObject` and `setStrategies`.
We need to add more test cases for this class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on issue #16290: Add more unit test for ShardingRuleAlgorithmProviderConfigurationYamlSwapper
Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #16290:
URL: https://github.com/apache/shardingsphere/issues/16290#issuecomment-1174618435
@itsAfnanAlam Hi, there are no progress for long time, I just cancel assign to you and make the issue open to pick up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on issue #16290: Add more unit test for ShardingRuleAlgorithmProviderConfigurationYamlSwapper
Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #16290:
URL: https://github.com/apache/shardingsphere/issues/16290#issuecomment-1193064092
This issue contains lots message, I just close this one and create a new one to continue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] itsAfnanAlam commented on issue #16290: Add more unit test for ShardingRuleAlgorithmProviderConfigurationYamlSwapper
Posted by GitBox <gi...@apache.org>.
itsAfnanAlam commented on issue #16290:
URL: https://github.com/apache/shardingsphere/issues/16290#issuecomment-1087052097
Thank you @strongduanmu, could you please guide me on how can I add more unit tests for ShardingRuleAlgorithmProviderConfigurationYamlSwapper?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on issue #16290: Add more unit test for ShardingRuleAlgorithmProviderConfigurationYamlSwapper
Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #16290:
URL: https://github.com/apache/shardingsphere/issues/16290#issuecomment-1193063707
> * ShardingRuleAlgorithmProviderConfigurationYamlSwapper
Get getRuleTagName, getOrder and getTypeClass are static impl, do not need add test cases, I just remove them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu closed issue #16290: Add more unit test for ShardingRuleAlgorithmProviderConfigurationYamlSwapper
Posted by GitBox <gi...@apache.org>.
terrymanu closed issue #16290: Add more unit test for ShardingRuleAlgorithmProviderConfigurationYamlSwapper
URL: https://github.com/apache/shardingsphere/issues/16290
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on issue #16290: Add more unit test for ShardingRuleAlgorithmProviderConfigurationYamlSwapper
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #16290:
URL: https://github.com/apache/shardingsphere/issues/16290#issuecomment-1087183344
@itsAfnanAlam You can refer to EncryptRuleAlgorithmProviderConfigurationYamlSwapperTest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org