[GitHub] [iceberg] rdblue commented on a diff in pull request #4902: Spark-3.2: Support Zorder option for rewrite_data_files stored procedure

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #4902:
URL: https://github.com/apache/iceberg/pull/4902#discussion_r913212119


##########
api/src/main/java/org/apache/iceberg/expressions/Zorder.java:
##########
@@ -17,24 +17,19 @@
  * under the License.
  */
 
-package org.apache.spark.sql.catalyst.plans.logical
+package org.apache.iceberg.expressions;
 
-import org.apache.iceberg.NullOrder
-import org.apache.iceberg.Schema
-import org.apache.iceberg.SortDirection
-import org.apache.iceberg.SortOrder
-import org.apache.iceberg.expressions.Term
+import java.util.Arrays;
+import java.util.List;
 
-class SortOrderParserUtil {
+public class Zorder implements Term {

Review Comment:
   Thinking about this a bit more, I think we should move this out of the API module. We don't want to make guarantees about this class since it isn't a "real" part of the expression library yet. It is mostly a placeholder. Can you move this to core?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org