You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "mhansonp (GitHub)" <gi...@apache.org> on 2018/09/13 00:11:01 UTC
[GitHub] [geode] mhansonp opened pull request #2463: Geode 5428:
Refactored DurableClientTests due to massive duplication
This code was not in a good state. So the code has been refactored to not only address issues
where the code was giving bad feedback, but to address the impressive structural duplication.
Things done:
-Extracted a bunch of methods
-Added new Test files for test subjects that should have been separate
-Split out a base class so there was no inheritance of test classes to do basic things.
-Reparented classes that were inheriting from test classes
Co-Authored-By: Galen O'Sullivan <go...@pivotal.io>
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
[ Full content available at: https://github.com/apache/geode/pull/2463 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] galen-pivotal commented on pull request #2463: Geode
5428: Refactored DurableClientTests due to massive duplication
Posted by "galen-pivotal (GitHub)" <gi...@apache.org>.
Can this be replaced with Awaitility?
[ Full content available at: https://github.com/apache/geode/pull/2463 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] mhansonp commented on issue #2463: Geode 5428:
Refactored DurableClientTests due to massive duplication
Posted by "mhansonp (GitHub)" <gi...@apache.org>.
@galen-pivotal @WireBaron @upthewaterspout @balesh2 Can you all review this PR?
[ Full content available at: https://github.com/apache/geode/pull/2463 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] upthewaterspout closed pull request #2463: Geode
5428: Refactored DurableClientTests due to massive duplication
Posted by "upthewaterspout (GitHub)" <gi...@apache.org>.
[ pull request closed by upthewaterspout ]
[ Full content available at: https://github.com/apache/geode/pull/2463 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] mhansonp commented on issue #2463: Geode 5428:
Refactored DurableClientTests due to massive duplication
Posted by "mhansonp (GitHub)" <gi...@apache.org>.
@upthewaterspout @WireBaron @balesh2 Please review when you get the chance.
[ Full content available at: https://github.com/apache/geode/pull/2463 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] galen-pivotal commented on pull request #2463: Geode
5428: Refactored DurableClientTests due to massive duplication
Posted by "galen-pivotal (GitHub)" <gi...@apache.org>.
This test appears to be ignored. Also it fails on my machine (when run with IntelliJ). Maybe a good future task.
[ Full content available at: https://github.com/apache/geode/pull/2463 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] mhansonp commented on pull request #2463: Geode
5428: Refactored DurableClientTests due to massive duplication
Posted by "mhansonp (GitHub)" <gi...@apache.org>.
There seems to be some delay with the registering of interest. I'm not fond of this wait, but there isn't a better way I saw. Nothing to check for that would provide good feedback. I am open to suggestions.
[ Full content available at: https://github.com/apache/geode/pull/2463 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] mhansonp commented on pull request #2463: Geode
5428: Refactored DurableClientTests due to massive duplication
Posted by "mhansonp (GitHub)" <gi...@apache.org>.
This is a magic timeout. Remove it and things fail. Add it in and things are happy. I have no idea what this is really affecting, but it is necessary to work properly.
[ Full content available at: https://github.com/apache/geode/pull/2463 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org