[GitHub] [incubator-yunikorn-release] kingamarton commented on a change in pull request #7: [YUNIKORN-167] Fixed release tool after helm chart related changes

[GitBox <gi...@apache.org>]

kingamarton commented on a change in pull request #7:
URL: https://github.com/apache/incubator-yunikorn-release/pull/7#discussion_r436545219



##########
File path: tools/build-release.py
##########
@@ -41,19 +42,16 @@ def build_release():
     release_base = os.path.join(staging_dir, release_package_name)
     release_top_path = os.path.join(os.path.dirname(tools_dir),
         "release-top-level-artifacts")
+    helm_chart_path = os.path.join(os.path.dirname(tools_dir),
+        "helm-charts")

Review comment:
       I don't think we should include the helm charts for all versions, since the released ones can be installed without having this files. 
   I think the better solution is to change 0.8.0 version from the helm charts to latest. When testing it, we will need to change the image version to the locally built ones as mentioned in the README: https://github.com/apache/incubator-yunikorn-release/blob/master/release-top-level-artifacts/README.md
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org