You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kudu.apache.org by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org> on 2016/09/15 22:24:20 UTC

[jira] [Resolved] (KUDU-641) Fix AUTO_FLUSH_SYNC and test it

     [ https://issues.apache.org/jira/browse/KUDU-641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jean-Daniel Cryans resolved KUDU-641.
-------------------------------------
       Resolution: Invalid
    Fix Version/s: NA

This code completely changed.

> Fix AUTO_FLUSH_SYNC and test it
> -------------------------------
>
>                 Key: KUDU-641
>                 URL: https://issues.apache.org/jira/browse/KUDU-641
>             Project: Kudu
>          Issue Type: Bug
>          Components: client
>    Affects Versions: M5
>            Reporter: Jean-Daniel Cryans
>             Fix For: NA
>
>
> AUTO_FLUSH_SYNC is by all means implemented in the C++ client except for this wrong check in client.cc:
> {code}
> CHECK_EQ(data_->flush_mode_, MANUAL_FLUSH) << "TODO: handle other flush modes";
> {code}
> Simply changing this to CHECK_NE with AUTO_FLUSH_BACKGROUND makes it so that sync works. The reason we didn't notice this sooner is that we don't test AUTO_FLUSH_SYNC, so we should also fix that.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)