[jira] Commented: (HBASE-3241) check to see if we exceeded hbase.regionserver.maxlogs limit is incorrect

["ryan rawson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-3241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12932730#action_12932730 ] 

ryan rawson commented on HBASE-3241:
------------------------------------

i think kannan is correct here...

> check to see if we exceeded hbase.regionserver.maxlogs limit is incorrect
> -------------------------------------------------------------------------
>
>                 Key: HBASE-3241
>                 URL: https://issues.apache.org/jira/browse/HBASE-3241
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Kannan Muthukkaruppan
>
> In HLog.java:cleanOldLogs(), the number of logs left after archiving of old logs is computed as:
> {code}
>     int logCount = this.outputfiles.size() - logsToRemove;
> {code}
> However, the archival itself already removes the files that were archived from the "this.outputfiles" map. 
> So shouldn't the above logic simply be the following?
> {code}
>   int logCount = this.outputfiles.size();
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.