You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Jani Averbach <ja...@jaa.iki.fi> on 2005/06/03 22:31:11 UTC
Re: svn commit: r14968 - branches/server-l10n/subversion/libsvn_ra_dav
On 2005-06-03 16:01-0500, dlr@tigris.org wrote:
> Author: dlr
> Date: Fri Jun 3 16:01:29 2005
> New Revision: 14968
>
> Modified:
> branches/server-l10n/subversion/libsvn_ra_dav/util.c
>
> Log:
> * subversion/libsvn_ra_dav/util.c
> (parsed_request): LC_MESSAGES isn't available on Windows, but we
> could use LC_ALL when calling setlocale() there. However, Windows
> and some Linux may return friendly aliases for the language and
> country codes, which do not appear to be permitted per section 3.10
> of RFC 2616. ifdef'd out sending of Accept-Language on Windows
> (general solution in the works). Duplicate the return value of
> setlocale(), since we'll be manipulating that memory (and it could
> be read-only).
As from lurker's point of view, should this explanation be located on
the code instead of the commit message?
BR, Jani
--
Jani Averbach
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r14968 -
branches/server-l10n/subversion/libsvn_ra_dav
Posted by "Daniel L. Rall" <dl...@finemaltcoding.com>.
On Fri, 2005-06-03 at 16:31 -0600, Jani Averbach wrote:
> On 2005-06-03 16:01-0500, dlr@tigris.org wrote:
> > Author: dlr
> > Date: Fri Jun 3 16:01:29 2005
> > New Revision: 14968
> >
> > Modified:
> > branches/server-l10n/subversion/libsvn_ra_dav/util.c
> >
> > Log:
> > * subversion/libsvn_ra_dav/util.c
> > (parsed_request): LC_MESSAGES isn't available on Windows, but we
> > could use LC_ALL when calling setlocale() there. However, Windows
> > and some Linux may return friendly aliases for the language and
> > country codes, which do not appear to be permitted per section 3.10
> > of RFC 2616. ifdef'd out sending of Accept-Language on Windows
> > (general solution in the works). Duplicate the return value of
> > setlocale(), since we'll be manipulating that memory (and it could
> > be read-only).
>
> As from lurker's point of view, should this explanation be located on
> the code instead of the commit message?
Yah, thanks for the comment, Jani. Fortunately, I ended up replacing
this code with a much simpler scheme after discussing things with people
on IRC (I think lunblad came up with the new scheme). See the changes
to this file in r14971 if you're interested.
- Dan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org