You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/12/08 14:34:23 UTC
[GitHub] [superset] michael-s-molina opened a new pull request, #22371: fix: DropdownContainer items width calculation
michael-s-molina opened a new pull request, #22371:
URL: https://github.com/apache/superset/pull/22371
### SUMMARY
Updates `DropdownContainer` to correctly calculate the width of the items when the `items` property changes.
Previously, the width calculation was only considering visible items which lead to resizing errors.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
https://user-images.githubusercontent.com/70410625/206473058-aec4c115-5978-472b-ae09-918d1e0f918f.mov
https://user-images.githubusercontent.com/70410625/206473121-1cd820c2-890b-4d05-ad9b-4141176ca1ba.mov
### TESTING INSTRUCTIONS
Check the videos for instructions.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #22371: fix: DropdownContainer items width calculation
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #22371:
URL: https://github.com/apache/superset/pull/22371#issuecomment-1342899388
# [Codecov](https://codecov.io/gh/apache/superset/pull/22371?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22371](https://codecov.io/gh/apache/superset/pull/22371?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9a79dbe) into [master](https://codecov.io/gh/apache/superset/commit/f64423a7409955561a4a27dba6912ad34d717220?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f64423a) will **decrease** coverage by `0.00%`.
> The diff coverage is `33.33%`.
> :exclamation: Current head 9a79dbe differs from pull request most recent head ef12db6. Consider uploading reports for the commit ef12db6 to get more accurate results
```diff
@@ Coverage Diff @@
## master #22371 +/- ##
==========================================
- Coverage 66.87% 66.86% -0.01%
==========================================
Files 1847 1847
Lines 70561 70559 -2
Branches 7739 7739
==========================================
- Hits 47186 47178 -8
- Misses 21374 21381 +7
+ Partials 2001 2000 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `53.82% <33.33%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/22371?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rontend/src/components/DropdownContainer/index.tsx](https://codecov.io/gh/apache/superset/pull/22371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRHJvcGRvd25Db250YWluZXIvaW5kZXgudHN4) | `64.55% <33.33%> (-8.29%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina merged pull request #22371: fix: DropdownContainer items width calculation
Posted by GitBox <gi...@apache.org>.
michael-s-molina merged PR #22371:
URL: https://github.com/apache/superset/pull/22371
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org