You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/10/09 17:10:31 UTC

[GitHub] [cloudstack] rvalle opened a new issue #4393: Host KVM Installation, Who is responsible?

rvalle opened a new issue #4393:
URL: https://github.com/apache/cloudstack/issues/4393


   <!--
   Verify first that your issue/request is not already reported on GitHub.
   Also test if the latest release and master branch are affected too.
   Always add information AFTER of these HTML comments, but no need to delete the comments.
   -->
   
   ##### ISSUE TYPE
   <!-- Pick one below and delete the rest -->
    * Documentation Report
   
   ##### COMPONENT NAME
   <!--
   Categorize the issue, e.g. API, VR, VPN, UI, etc.
   -->
   ~~~
   KVM Node / Agent
   ~~~
   
   ##### CLOUDSTACK VERSION
   <!--
   New line separated list of affected versions, commit ID for issues on master branch.
   -->
   
   ~~~
   4.14
   ~~~
   
   ##### CONFIGURATION
   <!--
   Information about the configuration if relevant, e.g. basic network, advanced networking, etc.  N/A otherwise
   -->
   
   ##### OS / ENVIRONMENT
   <!--
   Information about the environment if relevant, N/A otherwise
   -->
   
   Ubuntu 18.04
   
   ##### SUMMARY
   <!-- Explain the problem/feature briefly -->
   
   According to the documentation it is admins responsibility to configure libvirt and qemu, I have written Ansible playbooks to do so. However, I believe the agent is also configuring them, now ansible and cloudstack agent compete for changing those files.
   
   ##### STEPS TO REPRODUCE
   <!--
   For bugs, show exactly how to reproduce the problem, using a minimal test-case. Use Screenshots if accurate.
   
   For new features, show how the feature would be used.
   -->
   
   <!-- Paste example playbooks or commands between quotes below -->
   ~~~
   - Read ACS Manual: Quickstart/Installation of KVM
   - Write playbooks to automate configuration of KVM (libvirt, qemu, etc).
   - Configure your cluster
   - ACS Agent will alter the configuration
   - Following Playbook runs will break the configured system (i.e. when adding a new host to the cluster).
   ~~~
   
   <!-- You can also paste gist.github.com links for larger files -->
   
   ##### EXPECTED RESULTS
   <!-- What did you expect to happen when running the steps above? -->
   
   ~~~
   The responsibility over configuration files should be clear, either the Administrator or ACS.
   When responsibility is shared a conf.d directory pattern should be used.
   So I expect that either my configuration is not overridden or that ACS will deal with the configuration.
   
   ~~~
   
   ##### ACTUAL RESULTS
   <!-- What actually happened? -->
   
   <!-- Paste verbatim command output between quotes below -->
   ~~~
   Both my playbooks and ACS Agent keep fighting for control of KVM/Libvirt configuration files.
   ~~~
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on issue #4393: Host KVM Installation, Who is responsible for configuration files?

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #4393:
URL: https://github.com/apache/cloudstack/issues/4393#issuecomment-773998793


   closing this @rvalle 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rvalle edited a comment on issue #4393: Host KVM Installation, Who is responsible for configuration files?

Posted by GitBox <gi...@apache.org>.
rvalle edited a comment on issue #4393:
URL: https://github.com/apache/cloudstack/issues/4393#issuecomment-706657178


   ... it looks like ACS is automatically doing the changes requests in the documentation by itself.
   at least that is how it looks on Ubuntu 18.04...
   
   running some tests of my deployment playbooks wihtout configuring libvirt/qemu at all.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rvalle commented on issue #4393: Host KVM Installation, Who is responsible for configuration files?

Posted by GitBox <gi...@apache.org>.
rvalle commented on issue #4393:
URL: https://github.com/apache/cloudstack/issues/4393#issuecomment-776526353


   better late than never... it surprises me to be the #1 pull request, 
   @DaanHoogland is this supposed to be how you address doc changes?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland closed issue #4393: Host KVM Installation, Who is responsible for configuration files?

Posted by GitBox <gi...@apache.org>.
DaanHoogland closed issue #4393:
URL: https://github.com/apache/cloudstack/issues/4393


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on issue #4393: Host KVM Installation, Who is responsible for configuration files?

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #4393:
URL: https://github.com/apache/cloudstack/issues/4393#issuecomment-762878761


   > @DaanHoogland I am following up with this issue.
   > 
   > @weizhouapache the changes that you mention are they triggered when the host is added?
   
   @rvalle yes. it is part of cloudstack-setup-agent. more details at
   https://github.com/apache/cloudstack/blob/master/python/lib/cloudutils/syscfg.py
   https://github.com/apache/cloudstack/blob/master/python/lib/cloudutils/serviceConfig.py
   
   If there are two physical networks, you have to configure cloudbr0 and cloudbr1 manually, as it only configures the cloudbr0.
   It does not work for ubuntu 20.04
   
   
   > I think we should include a mention on the documentation that the installation, but I am not sure what to, perhaps:
   > 
   > > Please note that Cloudstack will automatically perform basic configuration of the agent and libvirt when the host is added. This is relevant if you are planning to automate the deployment of your KVM hosts.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rvalle commented on issue #4393: Host KVM Installation, Who is responsible for configuration files?

Posted by GitBox <gi...@apache.org>.
rvalle commented on issue #4393:
URL: https://github.com/apache/cloudstack/issues/4393#issuecomment-771419401


   @DaanHoogland yes, I will do. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rvalle commented on issue #4393: Host KVM Installation, Who is responsible for configuration files?

Posted by GitBox <gi...@apache.org>.
rvalle commented on issue #4393:
URL: https://github.com/apache/cloudstack/issues/4393#issuecomment-776624567


   thanks! no idea how it happened. first time I edit a file inside github. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rvalle commented on issue #4393: Host KVM Installation, Who is responsible for configuration files?

Posted by GitBox <gi...@apache.org>.
rvalle commented on issue #4393:
URL: https://github.com/apache/cloudstack/issues/4393#issuecomment-706669108


   @weizhouapache thanks for pointing out.
   
   I tried to deploy an ACS test cluster from scratch without touching these files:
   ```
   TASK [privazio.vdc.cloudstack-node : Install Cloudstack agent packages in Debian derivatives] ***
   changed: [compute2]
   changed: [compute1]
   TASK [privazio.vdc.cloudstack-node : Configure Cloudstack node firewall rules] ***
   changed: [compute1]
   changed: [compute2]
   TASK [privazio.vdc.cloudstack-node : Configure qemu] ***************************
   skipping: [compute1]
   skipping: [compute2]
   TASK [privazio.vdc.cloudstack-node : Configure libvirtd] ***********************
   skipping: [compute1]
   skipping: [compute2]
   TASK [privazio.vdc.cloudstack-node : Configure libvirtd defaults] **************
   skipping: [compute1]
   skipping: [compute2]
   TASK [privazio.vdc.cloudstack-node : Start Cloudstack node services] ***********
   ok: [compute1] => (item=libvirtd)
   ok: [compute2] => (item=libvirtd)
   ```
   And it turns out the cluster is fully functional. 
   
   ![Screenshot_2020-10-11 CloudStack](https://user-images.githubusercontent.com/412837/95673460-f3f0fc00-0ba8-11eb-8667-7185cad6fbdf.png)
   
   I guess the installation documentation is out of date, at least for Ubuntu, with initial libvirt configuration fully performed by ACS. 
   
   @andrijapanicsb helped me before with another similar issue related to Firewall rules, where the documentation lists all the required rules but some rules for the link-local came from somewhere else... when placing the firewall under configuration management a similar problem came up.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on issue #4393: Host KVM Installation, Who is responsible for configuration files?

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #4393:
URL: https://github.com/apache/cloudstack/issues/4393#issuecomment-776527389


   @rvalle you created a pull request to your own fork of the repo. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rvalle commented on issue #4393: Host KVM Installation, Who is responsible for configuration files?

Posted by GitBox <gi...@apache.org>.
rvalle commented on issue #4393:
URL: https://github.com/apache/cloudstack/issues/4393#issuecomment-762809950


   @DaanHoogland I am following up with this issue. 
   
   @weizhouapache the changes that you mention are they triggered when the host is added? 
   
   I think we should include a mention on the documentation that the installation, but I am not sure what to, perhaps:
   
   > Please note that Cloudstack will automatically perform basic configuration of the agent and libvirt when the host is added. This is relevant if you are planning to automate the deployment of your KVM hosts. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on issue #4393: Host KVM Installation, Who is responsible for configuration files?

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #4393:
URL: https://github.com/apache/cloudstack/issues/4393#issuecomment-706658497


   @rvalle cloudstack makes some basic changes on network/libvirt/system when setup cloudstack agent.
   
   services
   https://github.com/apache/cloudstack/blob/master/python/lib/cloudutils/syscfg.py#L157-L167
   for libvirt
   https://github.com/apache/cloudstack/blob/master/python/lib/cloudutils/serviceConfig.py#L559
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rvalle commented on issue #4393: Host KVM Installation, Who is responsible for configuration files?

Posted by GitBox <gi...@apache.org>.
rvalle commented on issue #4393:
URL: https://github.com/apache/cloudstack/issues/4393#issuecomment-776517667


   OK I see is a different project... 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rvalle commented on issue #4393: Host KVM Installation, Who is responsible for configuration files?

Posted by GitBox <gi...@apache.org>.
rvalle commented on issue #4393:
URL: https://github.com/apache/cloudstack/issues/4393#issuecomment-771419401


   @DaanHoogland yes, I will do. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on issue #4393: Host KVM Installation, Who is responsible for configuration files?

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #4393:
URL: https://github.com/apache/cloudstack/issues/4393#issuecomment-770907900


   @rvalle wil you send a PR to the docs repo?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rvalle commented on issue #4393: Host KVM Installation, Who is responsible for configuration files?

Posted by GitBox <gi...@apache.org>.
rvalle commented on issue #4393:
URL: https://github.com/apache/cloudstack/issues/4393#issuecomment-706657178


   I am running some tests, it looks like ACS is automatically doing the changes requests in the documentation by itself.
   at least that is how it looks on Ubuntu 18.04...
   
   running some tests of my deployment playbooks wihtout configuring libvirt/qemu at all.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rvalle commented on issue #4393: Host KVM Installation, Who is responsible for configuration files?

Posted by GitBox <gi...@apache.org>.
rvalle commented on issue #4393:
URL: https://github.com/apache/cloudstack/issues/4393#issuecomment-776517406


   @DaanHoogland sorry for the delay, I was implementing the new inventory plugin for ansible modules.
   
   Can you point me where the documentation source is?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org