You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Matthew Jacobs (Code Review)" <ge...@cloudera.org> on 2016/10/27 20:18:34 UTC
[Impala-ASF-CR] IMPALA-4384: NPE when cols list has trailing comma
Matthew Jacobs has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4869
Change subject: IMPALA-4384: NPE when cols list has trailing comma
......................................................................
IMPALA-4384: NPE when cols list has trailing comma
The changes to introduce new PRIMARY KEY syntax allowed for
a table definition to have a list of cols, optionally
followed by a PRIMARY KEY clause. However, this rule
was broken and would allow for the list of columns followed
by a trailing comma.
[localhost:21000] > create table foo (id int, x int,);
Query: create table foo (id int, x int,)
ERROR: AnalysisException: null
CAUSED BY: NullPointerException: null
Change-Id: Ibc394dd7e687b501ae7887a51bed2f441d562760
---
M fe/src/main/cup/sql-parser.cup
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
2 files changed, 4 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/4869/1
--
To view, visit http://gerrit.cloudera.org:8080/4869
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibc394dd7e687b501ae7887a51bed2f441d562760
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
[Impala-ASF-CR] IMPALA-4384: NPE when cols list has trailing comma
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-4384: NPE when cols list has trailing comma
......................................................................
IMPALA-4384: NPE when cols list has trailing comma
The changes to introduce new PRIMARY KEY syntax allowed for
a table definition to have a list of cols, optionally
followed by a PRIMARY KEY clause. However, this rule
was broken and would allow for the list of columns followed
by a trailing comma.
[localhost:21000] > create table foo (id int, x int,);
Query: create table foo (id int, x int,)
ERROR: AnalysisException: null
CAUSED BY: NullPointerException: null
Change-Id: Ibc394dd7e687b501ae7887a51bed2f441d562760
Reviewed-on: http://gerrit.cloudera.org:8080/4869
Reviewed-by: Matthew Jacobs <mj...@cloudera.com>
Tested-by: Internal Jenkins
---
M fe/src/main/cup/sql-parser.cup
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
2 files changed, 4 insertions(+), 10 deletions(-)
Approvals:
Matthew Jacobs: Looks good to me, approved
Internal Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4869
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibc394dd7e687b501ae7887a51bed2f441d562760
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
[Impala-ASF-CR] IMPALA-4384: NPE when cols list has trailing comma
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4384: NPE when cols list has trailing comma
......................................................................
Patch Set 2: Code-Review+2
rebase
--
To view, visit http://gerrit.cloudera.org:8080/4869
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc394dd7e687b501ae7887a51bed2f441d562760
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4384: NPE when cols list has trailing comma
Posted by "Dimitris Tsirogiannis (Code Review)" <ge...@cloudera.org>.
Dimitris Tsirogiannis has posted comments on this change.
Change subject: IMPALA-4384: NPE when cols list has trailing comma
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4869
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc394dd7e687b501ae7887a51bed2f441d562760
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4384: NPE when cols list has trailing comma
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-4384: NPE when cols list has trailing comma
......................................................................
Patch Set 1: Verified-1
Build failed: http://sandbox.jenkins.cloudera.com/job/impala-external-gerrit-verify-merge-ASF/390/
--
To view, visit http://gerrit.cloudera.org:8080/4869
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc394dd7e687b501ae7887a51bed2f441d562760
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4384: NPE when cols list has trailing comma
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-4384: NPE when cols list has trailing comma
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/4869
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc394dd7e687b501ae7887a51bed2f441d562760
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No