You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "walterddr (via GitHub)" <gi...@apache.org> on 2023/05/26 18:02:14 UTC
[GitHub] [pinot] walterddr opened a new pull request, #10809: [hotifx][multistage] order by limit is capped at 10_000
walterddr opened a new pull request, #10809:
URL: https://github.com/apache/pinot/pull/10809
SortOperator accidentally use the initial holder capacity as the limit parameter. this PR fixes this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang merged pull request #10809: [multistage][bugfix] order by limit is capped at 10_000
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang merged PR #10809:
URL: https://github.com/apache/pinot/pull/10809
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #10809: [multistage][bugfix] order by limit is capped at 10_000
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #10809:
URL: https://github.com/apache/pinot/pull/10809#issuecomment-1564786197
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/10809?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#10809](https://app.codecov.io/gh/apache/pinot/pull/10809?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (5b4058c) into [master](https://app.codecov.io/gh/apache/pinot/commit/5ee6e137c02e3e0a149a7c44dd6a9f5deb29cb5d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (5ee6e13) will **decrease** coverage by `56.60%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #10809 +/- ##
=============================================
- Coverage 70.23% 13.64% -56.60%
+ Complexity 6524 439 -6085
=============================================
Files 2164 2110 -54
Lines 116329 113839 -2490
Branches 17591 17294 -297
=============================================
- Hits 81706 15531 -66175
- Misses 28905 97038 +68133
+ Partials 5718 1270 -4448
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `?` | |
| integration2 | `?` | |
| unittests1 | `?` | |
| unittests2 | `13.64% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/pinot/pull/10809?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...che/pinot/query/runtime/operator/SortOperator.java](https://app.codecov.io/gh/apache/pinot/pull/10809?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtcXVlcnktcnVudGltZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvcXVlcnkvcnVudGltZS9vcGVyYXRvci9Tb3J0T3BlcmF0b3IuamF2YQ==) | `0.00% <0.00%> (-93.85%)` | :arrow_down: |
... and [1707 files with indirect coverage changes](https://app.codecov.io/gh/apache/pinot/pull/10809/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #10809: [multistage][bugfix] order by limit is capped at 10_000
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on code in PR #10809:
URL: https://github.com/apache/pinot/pull/10809#discussion_r1210629473
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/SortOperator.java:
##########
@@ -82,7 +86,7 @@ public SortOperator(OpChainExecutionContext context, MultiStageOperator upstream
} else {
// Use the opposite direction as specified by the collation directions since we need the PriorityQueue to decide
// which elements to keep and which to remove based on the limits.
- _priorityQueue = new PriorityQueue<>(_numRowsToKeep,
+ _priorityQueue = new PriorityQueue<>(defaultHolderCapacity,
Review Comment:
Use min of the 2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org