You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Tomoko Uchida (Jira)" <ji...@apache.org> on 2022/05/07 15:50:00 UTC
[jira] [Updated] (LUCENE-10561) Reduce member visibility of ArabicStemmer, ArabicNormalizer, and PersianNormalizer
[ https://issues.apache.org/jira/browse/LUCENE-10561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tomoko Uchida updated LUCENE-10561:
-----------------------------------
Description:
This is a spin-off of [LUCENE-10312].
Constants and methods in those classes are exposed to the outside packages; we should be able to limit the visibility to {{private}} or, at least to {{package private}}.
This change breaks backward compatibility so should be applied to the main branch (10.0) only, and a MIGRATE entry may be needed.
Also, they seem unchanged since 2008, we could refactor them to embrace newer Java APIs as we did in [https://github.com/apache/lucene/pull/540].
was:
This is a spin-off of [LUCENE-10312].
Constants and methods in those classes are exposed to outside packages; we should be able to limit the visibility to {{private}} or, at least to {{package private}}.
This change breaks backward compatibility so should be applied to only main branch, and a MIGRATION entry may be needed.
Also, they seem unchanged since 2008, we could refactor them to embrace newer Java APIs as we did in [https://github.com/apache/lucene/pull/540].
> Reduce member visibility of ArabicStemmer, ArabicNormalizer, and PersianNormalizer
> ----------------------------------------------------------------------------------
>
> Key: LUCENE-10561
> URL: https://issues.apache.org/jira/browse/LUCENE-10561
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Tomoko Uchida
> Priority: Minor
>
> This is a spin-off of [LUCENE-10312].
> Constants and methods in those classes are exposed to the outside packages; we should be able to limit the visibility to {{private}} or, at least to {{package private}}.
> This change breaks backward compatibility so should be applied to the main branch (10.0) only, and a MIGRATE entry may be needed.
> Also, they seem unchanged since 2008, we could refactor them to embrace newer Java APIs as we did in [https://github.com/apache/lucene/pull/540].
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org