[jira] Updated: (HDFS-456) Problems with dfs.name.edits.dirs as URI

["Jonathan Gray (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HDFS-456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Gray updated HDFS-456:
-------------------------------

    Attachment: HDFS-456-clean.patch

Over in HBase, we have not been able to run our unit tests on Windows in 0.21 because of URI-related errors in MiniDFSCluster.

With this patch, I am now able to run our unit tests on Windows.  I used to see messages like this:

{noformat}
2009-10-23 13:18:44,224 ERROR [main] namenode.FSNamesystem(354): Error while processing URI: C:\eclipse\HBase 0.21 Trunk SVN\build\hbase\test\dfs\name1. The error message was: Illegal character in opaque part at index 2: C:\eclipse\HBase 0.21 Trunk SVN\build\hbase\test\dfs\name1
{noformat}

With the patch, I now see:

{noformat}
2009-10-23 13:28:55,823 WARN  [main] common.Util(50): Path C:\eclipse\HBase 0.21 Trunk SVN\build\hbase\test\dfs\name1 should be specified as a URI in configuration files. Reverting to the default file scheme
{noformat}

And tests now run as expected.  +1 from me and others over in HBase.

Attached is a patch that applies cleanly to the current 0.21 branch, no other changes.  Thanks Luca!

> Problems with dfs.name.edits.dirs as URI
> ----------------------------------------
>
>                 Key: HDFS-456
>                 URL: https://issues.apache.org/jira/browse/HDFS-456
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Shvachko
>            Assignee: Luca Telloli
>            Priority: Blocker
>             Fix For: 0.21.0
>
>         Attachments: failing-tests.zip, HDFS-456-clean.patch, HDFS-456.patch, HDFS-456.patch, HDFS-456.patch, HDFS-456.patch, HDFS-456.patch, HDFS-456.patch, HDFS-456.patch, HDFS-456.patch
>
>
> There are several problems with recent commit of HDFS-396.
> # It does not work with default configuration "file:///". Throws {{IllegalArgumentException}}.
> # *ALL* hdfs tests fail on Windows because "C:\mypath" is treated as an illegal URI. Backward compatibility is not provided.
> # {{IllegalArgumentException}} should not be thrown within hdfs code because it is a {{RuntimException}}. We should throw {{IOException}} instead. This was recently discussed in another jira.
> # Why do we commit patches without running unit tests and test-patch? This is the minimum requirement for a patch to qualify as committable, right?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.