[GitHub] [superset] zhaoyongjie commented on a change in pull request #17965: refactor: move superset-ui dependencies to peerDependencies

[GitBox <gi...@apache.org>]

zhaoyongjie commented on a change in pull request #17965:
URL: https://github.com/apache/superset/pull/17965#discussion_r780311462



##########
File path: superset-frontend/package.json
##########
@@ -51,9 +51,9 @@
     "plugins:build-assets": "node ./scripts/copyAssets.js",
     "plugins:build-storybook": "cd packages/superset-ui-demo && npm run build-storybook",
     "plugins:chromatic": "cd packages/superset-ui-demo && npm run chromatic",
-    "plugins:create-conventional-version": "npm run prune && lerna version --conventional-commits --create-release github --yes",
-    "plugins:create-minor-version": "npm run prune && lerna version minor --yes",
-    "plugins:create-patch-version": "npm run prune && lerna version patch --yes",
+    "plugins:create-conventional-version": "npm run prune && lerna version --conventional-commits --create-release github --no-private --yes",

Review comment:
       do not change version of private package: `superset-ui-demo`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org