You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/12/30 23:00:57 UTC
[GitHub] [kafka] hachikuji opened a new pull request #9803: MINOR: Don't include stack trace for StateChangeFailedException
hachikuji opened a new pull request #9803:
URL: https://github.com/apache/kafka/pull/9803
The stack trace for `StateChangeFailedException` is useless since the exception is just used to propagate an error message to the state change logger. This patch eliminates the stack trace which should help to clean up logging a little bit.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji closed pull request #9803: MINOR: Don't include stack trace for StateChangeFailedException
Posted by GitBox <gi...@apache.org>.
hachikuji closed pull request #9803:
URL: https://github.com/apache/kafka/pull/9803
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji commented on pull request #9803: MINOR: Don't include stack trace for StateChangeFailedException
Posted by GitBox <gi...@apache.org>.
hachikuji commented on pull request #9803:
URL: https://github.com/apache/kafka/pull/9803#issuecomment-752783760
@ijuma @chia7712 Thoughts on this PR? I was getting tired of seeing these useless traces in logging...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #9803: MINOR: Don't include stack trace for StateChangeFailedException
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #9803:
URL: https://github.com/apache/kafka/pull/9803#issuecomment-752846372
> The stack trace for StateChangeFailedException is useless since the exception is just used to propagate an error message to the state change logger.
https://github.com/apache/kafka/blob/afa5423356d3d2a2135a51200573b45d097f6d60/core/src/main/scala/kafka/controller/KafkaController.scala#L1208 Does this case also propagate error message only?
For another, how about having a variety of ```logFailedStateChange``` which accepts error message (string) rather than ```Exception``` type?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org