You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/09/24 07:02:13 UTC
[GitHub] [activemq-artemis] franz1981 opened a new pull request #3771: ARTEMIS-3496 Replica connection to its live should fail fast
franz1981 opened a new pull request #3771:
URL: https://github.com/apache/activemq-artemis/pull/3771
https://issues.apache.org/jira/browse/ARTEMIS-3496
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gtully merged pull request #3771: ARTEMIS-3496 Replica connection to its live should fail fast
Posted by GitBox <gi...@apache.org>.
gtully merged pull request #3771:
URL: https://github.com/apache/activemq-artemis/pull/3771
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] franz1981 commented on pull request #3771: ARTEMIS-3496 Replica connection to its live should fail fast
Posted by GitBox <gi...@apache.org>.
franz1981 commented on pull request #3771:
URL: https://github.com/apache/activemq-artemis/pull/3771#issuecomment-928098695
@clebertsuconic I'm going to add a separate test for this tomorrow: I've rebased and now the CI is fully green with this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3771: ARTEMIS-3496 Replica connection to its live should fail fast
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3771:
URL: https://github.com/apache/activemq-artemis/pull/3771#issuecomment-926585839
it was set to 1 as in not meant to retry.. .a single connection...
its a bug... I meant for one connection only.
Replication and clustering should have the retries through the cluster bridge and clustered connection. not through the serverLocator.
Is there a test that fails with this? run the whole test suite just in case.. and if you can add a failing test it would be even greater.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] franz1981 commented on pull request #3771: ARTEMIS-3496 Replica connection to its live should fail fast
Posted by GitBox <gi...@apache.org>.
franz1981 commented on pull request #3771:
URL: https://github.com/apache/activemq-artemis/pull/3771#issuecomment-927792940
> Is there a test that fails with this?
I'm still investigating on multiple test failure *after* applied this change :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gtully commented on pull request #3771: ARTEMIS-3496 Replica connection to its live should fail fast
Posted by GitBox <gi...@apache.org>.
gtully commented on pull request #3771:
URL: https://github.com/apache/activemq-artemis/pull/3771#issuecomment-937639379
I guess a test would be best, but this looks a trivial fix and it is important for time to recover from failure. I would like to see this in 2.19.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gtully commented on pull request #3771: ARTEMIS-3496 Replica connection to its live should fail fast
Posted by GitBox <gi...@apache.org>.
gtully commented on pull request #3771:
URL: https://github.com/apache/activemq-artemis/pull/3771#issuecomment-938750713
I started with mokito and wow was it involved, the end result is not pretty but it does validate the fix. comments welcome!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gtully commented on pull request #3771: ARTEMIS-3496 Replica connection to its live should fail fast
Posted by GitBox <gi...@apache.org>.
gtully commented on pull request #3771:
URL: https://github.com/apache/activemq-artemis/pull/3771#issuecomment-939948892
fair, I guess it is related to the use of the default port, that needs sorting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] franz1981 edited a comment on pull request #3771: ARTEMIS-3496 Replica connection to its live should fail fast
Posted by GitBox <gi...@apache.org>.
franz1981 edited a comment on pull request #3771:
URL: https://github.com/apache/activemq-artemis/pull/3771#issuecomment-927792940
> Is there a test that fails with this?
I'm still investigating on multiple test failure *after* applied this change :(
Probably I was using an old branch version that was leaking fds: just sent another round on the CI, let's see
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] franz1981 commented on pull request #3771: ARTEMIS-3496 Replica connection to its live should fail fast
Posted by GitBox <gi...@apache.org>.
franz1981 commented on pull request #3771:
URL: https://github.com/apache/activemq-artemis/pull/3771#issuecomment-928098695
@clebertsuconic I'm going to add a separate test for this tomorrow: I've rebased and now the CI is fully green with this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] franz1981 commented on pull request #3771: ARTEMIS-3496 Replica connection to its live should fail fast
Posted by GitBox <gi...@apache.org>.
franz1981 commented on pull request #3771:
URL: https://github.com/apache/activemq-artemis/pull/3771#issuecomment-926395483
@clebertsuconic do you remember any reason why `reconnect attempts` was set to 1 on purpose on the replica connection to its live?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gtully commented on pull request #3771: ARTEMIS-3496 Replica connection to its live should fail fast
Posted by GitBox <gi...@apache.org>.
gtully commented on pull request #3771:
URL: https://github.com/apache/activemq-artemis/pull/3771#issuecomment-937639379
I guess a test would be best, but this looks a trivial fix and it is important for time to recover from failure. I would like to see this in 2.19.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gemmellr commented on pull request #3771: ARTEMIS-3496 Replica connection to its live should fail fast
Posted by GitBox <gi...@apache.org>.
gemmellr commented on pull request #3771:
URL: https://github.com/apache/activemq-artemis/pull/3771#issuecomment-939896655
Main comment, without looking at the code, the tests all hung and caused the GHA job to time out after 6 hours.
The tests should have an appropriate timeout to stop any one test taking an excessive amount of time before failing (also makes clear which one goes bang when they do, aiding following analysis of what happened).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org